fix(tests): harden incident filter selectors and scroll visibility

Extract incident IDs from data-test attributes instead of text content
to avoid description text pollution. Use container existence check instead
of visibility assertion for 0-height dropdown. Add scrollIntoView and
.first() to fix viewport and multi-element ambiguity issues.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

Author: DavidRajnoha

web/cypress/e2e/incidents/01.incidents.cy.ts

@@ -95,12 +95,11 @@ describe('BVT: Incidents - UI', { tags: ['@smoke', '@incidents'] }, () => {
 
   it('6. Admin perspective - Incidents page - Bar click selection walkthrough', () => {
     cy.log('6.1 Load multi-incident fixture and verify chart bars are clickable');
+    incidentsPage.setDays('7 days');
     cy.mockIncidentFixture(
       'incident-scenarios/1-single-incident-firing-critical-and-warning-alerts.yaml',
     );
-    incidentsPage.goTo();
     incidentsPage.clearAllFilters();
-    incidentsPage.setDays('7 days');
     incidentsPage.elements.incidentsChartContainer().should('be.visible');
 
     cy.log('6.2 Select incident bar and verify table appears with expected alerts');

web/cypress/e2e/incidents/regression/01.reg_filtering.cy.ts

@@ -122,7 +122,7 @@ describe('Regression: Incidents Filtering', { tags: ['@incidents'] }, () => {
 
       cy.log('2.3 Select an incident by ID filter and verify table appears');
       incidentsPage.selectIncidentIdFilter(ids[0]);
-      incidentsPage.elements.incidentsTable().should('be.visible');
+      incidentsPage.elements.incidentsTable().scrollIntoView().should('be.visible');
       incidentsPage.elements.incidentsChartBarsGroups().should('have.length', 1);
 
       cy.log('2.4 Clear the Incident ID filter and verify all incidents return');
@@ -144,10 +144,10 @@ describe('Regression: Incidents Filtering', { tags: ['@incidents'] }, () => {
     cy.mockIncidentFixture('incident-scenarios/7-comprehensive-filtering-test-scenarios.yaml');
     incidentsPage.clearAllFilters();
     incidentsPage.selectIncidentIdFilter('etcd-critical-warning-001');
-    incidentsPage.elements.incidentsTable().should('be.visible');
+    incidentsPage.elements.incidentsTable().scrollIntoView().should('be.visible');
     incidentsPage.elements.incidentsTableComponentCell(0).should('contain.text', 'etcd');
     incidentsPage.expandRow(0);
-    incidentsPage.elements.incidentsDetailsTable().should('be.visible');
+    incidentsPage.elements.incidentsDetailsTable().scrollIntoView().should('be.visible');
     incidentsPage.elements
       .incidentsDetailsTable()
       .should('contain.text', 'EtcdClusterUnavailable001');

web/cypress/e2e/incidents/regression/04.reg_redux_effects.cy.ts

@@ -123,8 +123,8 @@ describe('Regression: Redux State Management', { tags: ['@incidents', '@incident
           .first()
           .click({ force: true });
 
-        incidentsPage.elements.alertsChartContainer().should('be.visible');
-        incidentsPage.elements.incidentIdFilterChip().should('be.visible');
+        incidentsPage.elements.alertsChartContainer().first().scrollIntoView().should('be.visible');
+        incidentsPage.elements.incidentIdFilterChip().first().scrollIntoView().should('be.visible');
 
         dropdown.setup();
 
@@ -153,11 +153,11 @@ describe('Regression: Redux State Management', { tags: ['@incidents', '@incident
     incidentsPage.elements.incidentsChartBarsVisiblePathsNonEmpty().first().click({ force: true });
 
     cy.log('3.4 Verify incident ID filter chip appears');
-    incidentsPage.elements.incidentIdFilterChip().should('be.visible');
+    incidentsPage.elements.incidentIdFilterChip().first().should('be.visible');
 
     cy.log('3.5 Verify both Critical and Incident ID chips are present');
     incidentsPage.elements.filterChipValue('Critical').should('be.visible');
-    incidentsPage.elements.incidentIdFilterChip().should('be.visible');
+    incidentsPage.elements.incidentIdFilterChip().first().should('be.visible');
 
     cy.log(
       '3.6 Deselect Critical and Apply Warning filter (which does not match the critical incident)',
@@ -174,7 +174,7 @@ describe('Regression: Redux State Management', { tags: ['@incidents', '@incident
 
     cy.log('3.8 Verify BOTH Warning filter and Incident ID filter are still applied');
     incidentsPage.elements.filterChipValue('Warning').should('be.visible');
-    incidentsPage.elements.incidentIdFilterChip().should('be.visible');
+    incidentsPage.elements.incidentIdFilterChip().first().should('be.visible');
 
     cy.log(
       'SUCCESS: Incident ID filter was not removed when non-matching severity filter was added',
@@ -187,7 +187,7 @@ describe('Regression: Redux State Management', { tags: ['@incidents', '@incident
 
     cy.log('3.10 With only Incident ID filter, incident should be visible again');
     incidentsPage.elements.incidentsChartBarsGroups().should('have.length', 1);
-    incidentsPage.elements.incidentIdFilterChip().should('be.visible');
+    incidentsPage.elements.incidentIdFilterChip().first().should('be.visible');
     cy.log('SUCCESS: Incident reappears when conflicting filter removed');
   });
 });

web/cypress/views/incidents-page.ts

@@ -189,7 +189,8 @@ export const incidentsPage = {
         .incidentsDetailsTable()
         .find('tbody tr')
         .eq(index)
-        .find('td[data-label="expanded-details-alertname"]'),
+        .find('td[data-label="expanded-details-alertname"]')
+        .scrollIntoView(),
     incidentsDetailsAlertRuleLink: (index: number) =>
       incidentsPage.elements
         .incidentsDetailsTable()
@@ -445,18 +446,21 @@ export const incidentsPage = {
 
     incidentsPage.ensureFilterTypeSelected('Incident ID');
     incidentsPage.elements.incidentIdFilterToggle().scrollIntoView().click({ force: true });
-    incidentsPage.elements.incidentIdFilterList().should('be.visible');
 
+    // Container has 0 height so .should('be.visible') fails on it.
+    // Empty list is valid (no incidents), so we wait for the container then read items.
+    // Extract IDs from data-test attributes to avoid reading text that includes descriptions.
+    const prefix = `${DataTestIDs.IncidentsPage.FiltersSelectOption}-incident id-`;
     return incidentsPage.elements
       .incidentIdFilterList()
-      .find('button[role="menuitem"] .pf-v6-c-menu__item-text')
-      .then(($texts) => {
+      .should('exist')
+      .then(($list) => {
+        const $items = $list.find(`[data-test^="${prefix}"]`);
         const ids: string[] = [];
-        $texts.each((_, el) => {
-          const text = Cypress.$(el).text().trim();
-          if (text) ids.push(text);
+        $items.each((_, el) => {
+          const id = Cypress.$(el).attr('data-test')?.slice(prefix.length);
+          if (id) ids.push(id);
         });
-        // Close the dropdown without selecting
         incidentsPage.elements.incidentIdFilterToggle().scrollIntoView().click({ force: true });
         return cy.wrap(ids, _qLog());
       });