Merge pull request #561 from openshift-bot/synchronize-upstream

NO-ISSUE: Synchronize From Upstream Repositories

Author: openshift-merge-bot[bot]

.bingo/Variables.mk

@@ -47,11 +47,11 @@ $(GOJQ): $(BINGO_DIR)/gojq.mod
 	@echo "(re)installing $(GOBIN)/gojq-v0.12.17"
 	@cd $(BINGO_DIR) && GOWORK=off $(GO) build -mod=mod -modfile=gojq.mod -o=$(GOBIN)/gojq-v0.12.17 "github.com/itchyny/gojq/cmd/gojq"
 
-GOLANGCI_LINT := $(GOBIN)/golangci-lint-v2.1.6
+GOLANGCI_LINT := $(GOBIN)/golangci-lint-v2.6.2
 $(GOLANGCI_LINT): $(BINGO_DIR)/golangci-lint.mod
 	@# Install binary/ries using Go 1.14+ build command. This is using bwplotka/bingo-controlled, separate go module with pinned dependencies.
-	@echo "(re)installing $(GOBIN)/golangci-lint-v2.1.6"
-	@cd $(BINGO_DIR) && GOWORK=off $(GO) build -mod=mod -modfile=golangci-lint.mod -o=$(GOBIN)/golangci-lint-v2.1.6 "github.com/golangci/golangci-lint/v2/cmd/golangci-lint"
+	@echo "(re)installing $(GOBIN)/golangci-lint-v2.6.2"
+	@cd $(BINGO_DIR) && GOWORK=off $(GO) build -mod=mod -modfile=golangci-lint.mod -o=$(GOBIN)/golangci-lint-v2.6.2 "github.com/golangci/golangci-lint/v2/cmd/golangci-lint"
 
 GORELEASER := $(GOBIN)/goreleaser-v1.26.2
 $(GORELEASER): $(BINGO_DIR)/goreleaser.mod

.bingo/golangci-lint.mod

@@ -1,7 +1,5 @@
 module _ // Auto generated by https://github.com/bwplotka/bingo. DO NOT EDIT
 
-go 1.24.2
+go 1.24.6
 
-toolchain go1.24.3
-
-require github.com/golangci/golangci-lint/v2 v2.1.6 // cmd/golangci-lint
+require github.com/golangci/golangci-lint/v2 v2.6.2 // cmd/golangci-lint

.bingo/golangci-lint.sum

@@ -18,7 +18,7 @@ CRD_REF_DOCS="${GOBIN}/crd-ref-docs-v0.2.0"
 
 GOJQ="${GOBIN}/gojq-v0.12.17"
 
-GOLANGCI_LINT="${GOBIN}/golangci-lint-v2.1.6"
+GOLANGCI_LINT="${GOBIN}/golangci-lint-v2.6.2"
 
 GORELEASER="${GOBIN}/goreleaser-v1.26.2"
 

.bingo/variables.env

@@ -0,0 +1,98 @@
+---
+description: Profile memory and CPU usage during e2e tests and analyze results
+---
+
+# Test Profiling
+
+Profile memory and CPU usage during e2e tests using the Go-based `bin/test-profile` tool.
+
+## Available Commands
+
+### /test-profile start [name]
+Start background profiling daemon. Collects heap/CPU profiles from operator-controller and catalogd every 10s.
+- Auto-stops after 3 consecutive collection failures (e.g., cluster teardown)
+- Use with any test command: `make test-e2e`, `make test-experimental-e2e`, etc.
+- Follow with `/test-profile stop` to generate analysis
+
+**Example:**
+```bash
+/test-profile start baseline
+make test-e2e
+/test-profile stop
+```
+
+### /test-profile stop
+Stop profiling daemon and generate analysis report. Cleans up port-forwards and empty profiles.
+
+### /test-profile run [name] [test-target]
+Automated workflow: start test, profile until completion, analyze.
+- Default test-target: `test-e2e`
+- Other targets: `test-experimental-e2e`, `test-upgrade-e2e`, etc.
+
+**Example:**
+```bash
+/test-profile run baseline test-e2e
+```
+
+### /test-profile analyze [name]
+Analyze existing profiles in `test-profiles/[name]/`. Generates markdown report with:
+- Memory/CPU growth patterns
+- Top allocators
+- OpenAPI, JSON, and cache hotspots
+
+### /test-profile compare [baseline] [optimized]
+Compare two test runs. Outputs to `test-profiles/comparisons/[baseline]-vs-[optimized].md`
+
+### /test-profile collect
+One-time snapshot of heap/CPU profiles from running pods. Saves to `test-profiles/manual/`
+
+## Implementation Steps
+
+When executing commands, I will:
+
+1. **Build tool**: `make build-test-profiler` (builds to `bin/test-profile`)
+2. **Execute command**: `./bin/test-profile [command] [args]`
+3. **For start/stop workflow**: Monitor daemon logs, handle errors gracefully
+4. **For run command**: Start test in background, monitor progress, analyze on completion
+5. **For analysis**: Present key findings from generated markdown reports
+
+## Configuration
+
+Environment variables (defaults shown):
+```bash
+TEST_PROFILE_COMPONENTS="operator-controller:olmv1-system:operator-controller-controller-manager:6060;catalogd:olmv1-system:catalogd-controller-manager:6060"
+TEST_PROFILE_INTERVAL=10           # seconds between collections
+TEST_PROFILE_CPU_DURATION=10       # CPU profiling duration
+TEST_PROFILE_MODE=both             # both|heap|cpu
+TEST_PROFILE_DIR=./test-profiles
+TEST_PROFILE_TEST_TARGET=test-e2e
+```
+
+## Output Structure
+
+```
+test-profiles/
+├── [name]/
+│   ├── operator-controller/
+│   │   ├── heap*.pprof
+│   │   └── cpu*.pprof
+│   ├── catalogd/
+│   │   ├── heap*.pprof
+│   │   └── cpu*.pprof
+│   ├── profiler.log
+│   └── analysis.md
+└── comparisons/
+    └── [name1]-vs-[name2].md
+```
+
+## Tool Location
+
+- Source: `hack/tools/test-profiling/` (Go-based CLI)
+- Binary: `bin/test-profile`
+- Make targets: `make build-test-profiler`, `make start-profiling/[name]`, `make stop-profiling`
+
+## Requirements
+
+- kubectl access to cluster
+- go tool pprof (for analysis)
+- Go version minimum from `hack/tools/test-profiling/go.mod` (for building)

.claude/commands/test-profile.md

@@ -38,8 +38,13 @@ vendor/
 \#*\#
 .\#*
 
-# AI temp files files
-.claude/
+# AI temp/local files
+.claude/settings.local.json
+.claude/history/
+.claude/cache/
+.claude/logs/
+.claude/.session*
+.claude/*.log
 
 # documentation website asset folder
 site

.gitignore

@@ -178,9 +178,13 @@ generate: $(CONTROLLER_GEN) #EXHELP Generate code containing DeepCopy, DeepCopyI
 	$(CONTROLLER_GEN) --load-build-tags=$(GO_BUILD_TAGS) object:headerFile="hack/boilerplate.go.txt" paths="./..."
 
 .PHONY: verify
-verify: k8s-pin kind-verify-versions fmt generate manifests update-tls-profiles crd-ref-docs #HELP Verify all generated code is up-to-date. Runs k8s-pin instead of just tidy.
+verify: k8s-pin kind-verify-versions fmt generate manifests update-tls-profiles crd-ref-docs verify-bingo #HELP Verify all generated code is up-to-date. Runs k8s-pin instead of just tidy.
 	git diff --exit-code
 
+.PHONY: verify-bingo
+verify-bingo: $(BINGO)
+	$(BINGO) get -v -t 15
+
 .PHONY: fix-lint
 fix-lint: $(GOLANGCI_LINT) #EXHELP Fix lint issues
 	$(GOLANGCI_LINT) run --fix --build-tags $(GO_BUILD_TAGS) $(GOLANGCI_LINT_ARGS)
@@ -385,7 +389,7 @@ kind-clean: $(KIND) #EXHELP Delete the kind cluster.
 	$(KIND) delete cluster --name $(KIND_CLUSTER_NAME)
 
 .PHONY: kind-verify-versions
-kind-verify-versions:
+kind-verify-versions: $(KIND)
 	env K8S_VERSION=v$(K8S_VERSION) KIND=$(KIND) GOBIN=$(GOBIN) hack/tools/validate_kindest_node.sh
 
 

Makefile

@@ -19,7 +19,6 @@ package v1
 import (
 	metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
 	"k8s.io/apimachinery/pkg/apis/meta/v1/unstructured"
-	"k8s.io/apimachinery/pkg/types"
 )
 
 const (
@@ -40,6 +39,7 @@ const (
 	ClusterExtensionRevisionReasonIncomplete                = "Incomplete"
 	ClusterExtensionRevisionReasonProgressing               = "Progressing"
 	ClusterExtensionRevisionReasonArchived                  = "Archived"
+	ClusterExtensionRevisionReasonMigrated                  = "Migrated"
 )
 
 // ClusterExtensionRevisionSpec defines the desired state of ClusterExtensionRevision.
@@ -66,10 +66,6 @@ type ClusterExtensionRevisionSpec struct {
 	// +listMapKey=name
 	// +optional
 	Phases []ClusterExtensionRevisionPhase `json:"phases,omitempty"`
-	// Previous references previous revisions that objects can be adopted from.
-	//
-	// +kubebuilder:validation:XValidation:rule="self == oldSelf", message="previous is immutable"
-	Previous []ClusterExtensionRevisionPrevious `json:"previous,omitempty"`
 }
 
 // ClusterExtensionRevisionLifecycleState specifies the lifecycle state of the ClusterExtensionRevision.
@@ -108,6 +104,7 @@ type ClusterExtensionRevisionObject struct {
 	// already existing on the cluster or even owned by another controller.
 	//
 	// +kubebuilder:default="Prevent"
+	// +kubebuilder:validation:Enum=Prevent;IfNoController;None
 	// +optional
 	CollisionProtection CollisionProtection `json:"collisionProtection,omitempty"`
 }
@@ -129,13 +126,6 @@ const (
 	CollisionProtectionNone CollisionProtection = "None"
 )
 
-type ClusterExtensionRevisionPrevious struct {
-	// +kubebuilder:validation:Required
-	Name string `json:"name"`
-	// +kubebuilder:validation:Required
-	UID types.UID `json:"uid"`
-}
-
 // ClusterExtensionRevisionStatus defines the observed state of a ClusterExtensionRevision.
 type ClusterExtensionRevisionStatus struct {
 	// +listType=map

api/v1/clusterextensionrevision_types.go

@@ -59,7 +59,6 @@ import (
 	"github.com/operator-framework/operator-controller/internal/catalogd/storage"
 	"github.com/operator-framework/operator-controller/internal/catalogd/webhook"
 	sharedcontrollers "github.com/operator-framework/operator-controller/internal/shared/controllers"
-	cacheutil "github.com/operator-framework/operator-controller/internal/shared/util/cache"
 	fsutil "github.com/operator-framework/operator-controller/internal/shared/util/fs"
 	httputil "github.com/operator-framework/operator-controller/internal/shared/util/http"
 	imageutil "github.com/operator-framework/operator-controller/internal/shared/util/image"
@@ -255,8 +254,6 @@ func run(ctx context.Context) error {
 
 	cacheOptions := crcache.Options{
 		ByObject: map[client.Object]crcache.ByObject{},
-		// Memory optimization: strip managed fields and large annotations from cached objects
-		DefaultTransform: cacheutil.StripManagedFieldsAndAnnotations(),
 	}
 
 	saKey, err := sautil.GetServiceAccount()