Skip to content

Commit e76c041

Browse files
author
OpenShift Bot
authored
Merge pull request #2112 from spadgett/binding-marked-for-deletion
Merged by openshift-bot
2 parents 63166c0 + 7c74cb5 commit e76c041

File tree

4 files changed

+30
-8
lines changed

4 files changed

+30
-8
lines changed

app/views/browse/service-instance.html

+6
Original file line numberDiff line numberDiff line change
@@ -39,6 +39,12 @@ <h1 class="contains-actions">
3939
<div class="container-fluid">
4040
<div class="row" ng-if="serviceInstance">
4141
<div class="col-md-12">
42+
<div ng-if="serviceInstance.metadata.deletionTimestamp" class="alert word-break alert-warning">
43+
<span class="pficon pficon-warning-triangle-o" aria-hidden="true"></span>
44+
<span class="sr-only">warning</span>
45+
<span class="strong">The service was marked for deletion</span>
46+
<span class="strong" am-time-ago="serviceInstance.metadata.deletionTimestamp"></span>.
47+
</div>
4248
<uib-tabset>
4349
<uib-tab active="selectedTab.details">
4450
<uib-tab-heading>Details</uib-tab-heading>

app/views/directives/_service-binding.html

+5-1
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,11 @@ <h3 ng-if="$ctrl.serviceClass">
1717
<small>created <span am-time-ago="$ctrl.binding.metadata.creationTimestamp"></span></small>
1818
</h3>
1919
</div>
20-
<div class="col-sm-7 col-md-6" ng-if="!($ctrl.binding | isBindingReady)">
20+
<div class="col-sm-7 col-md-6" ng-if="$ctrl.binding.metadata.deletionTimestamp">
21+
<span class="pficon pficon-warning-triangle-o" aria-hidden="true"></span>
22+
Marked for Deletion
23+
</div>
24+
<div class="col-sm-7 col-md-6" ng-if="!$ctrl.binding.metadata.deletionTimestamp && !($ctrl.binding | isBindingReady)">
2125
<status-icon status="'Pending'"></status-icon>Pending
2226
</div>
2327
</div>

app/views/overview/_service-instance-row.html

+4-3
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ <h3>
2424
</span>
2525
<span ng-switch-when="deleted">
2626
<span class="pficon pficon-warning-triangle-o" aria-hidden="true"></span>
27-
<span>Marked for Deletion</span>
27+
Marked for Deletion
2828
</span>
2929
<span ng-switch-when="pending">
3030
<span class="spinner spinner-xs spinner-inline" aria-hidden="true"></span>
@@ -102,7 +102,7 @@ <h3>
102102
<span class="pficon pficon-warning-triangle-o" aria-hidden="true"></span>
103103
<span class="sr-only">warning</span>
104104
<span class="strong">The service was marked for deletion</span>
105-
<span class="strong" am-time-ago="row.apiObject.metadata.deletionTimestamp"></span>
105+
<span class="strong" am-time-ago="row.apiObject.metadata.deletionTimestamp"></span>.
106106
</div>
107107
</div>
108108
</div>
@@ -162,7 +162,8 @@ <h3>
162162
</div>
163163
<div class="col-sm-7 col-md-6 overview-bindings">
164164
<span ng-if="binding.metadata.deletionTimestamp">
165-
<status-icon status="'Pending'"></status-icon> Deleting
165+
<span class="pficon pficon-warning-triangle-o" aria-hidden="true"></span>
166+
Marked for Deletion
166167
</span>
167168
<span ng-if="!(binding | isBindingReady) && !binding.metadata.deletionTimestamp">
168169
<status-icon status="'Pending'"></status-icon> Pending

dist/scripts/templates.js

+15-4
Original file line numberDiff line numberDiff line change
@@ -3712,6 +3712,12 @@ angular.module('openshiftConsoleTemplates', []).run(['$templateCache', function(
37123712
"<div class=\"container-fluid\">\n" +
37133713
"<div class=\"row\" ng-if=\"serviceInstance\">\n" +
37143714
"<div class=\"col-md-12\">\n" +
3715+
"<div ng-if=\"serviceInstance.metadata.deletionTimestamp\" class=\"alert word-break alert-warning\">\n" +
3716+
"<span class=\"pficon pficon-warning-triangle-o\" aria-hidden=\"true\"></span>\n" +
3717+
"<span class=\"sr-only\">warning</span>\n" +
3718+
"<span class=\"strong\">The service was marked for deletion</span>\n" +
3719+
"<span class=\"strong\" am-time-ago=\"serviceInstance.metadata.deletionTimestamp\"></span>.\n" +
3720+
"</div>\n" +
37153721
"<uib-tabset>\n" +
37163722
"<uib-tab active=\"selectedTab.details\">\n" +
37173723
"<uib-tab-heading>Details</uib-tab-heading>\n" +
@@ -5610,7 +5616,11 @@ angular.module('openshiftConsoleTemplates', []).run(['$templateCache', function(
56105616
"<small>created <span am-time-ago=\"$ctrl.binding.metadata.creationTimestamp\"></span></small>\n" +
56115617
"</h3>\n" +
56125618
"</div>\n" +
5613-
"<div class=\"col-sm-7 col-md-6\" ng-if=\"!($ctrl.binding | isBindingReady)\">\n" +
5619+
"<div class=\"col-sm-7 col-md-6\" ng-if=\"$ctrl.binding.metadata.deletionTimestamp\">\n" +
5620+
"<span class=\"pficon pficon-warning-triangle-o\" aria-hidden=\"true\"></span>\n" +
5621+
"Marked for Deletion\n" +
5622+
"</div>\n" +
5623+
"<div class=\"col-sm-7 col-md-6\" ng-if=\"!$ctrl.binding.metadata.deletionTimestamp && !($ctrl.binding | isBindingReady)\">\n" +
56145624
"<status-icon status=\"'Pending'\"></status-icon>Pending\n" +
56155625
"</div>\n" +
56165626
"</div>\n" +
@@ -12283,7 +12293,7 @@ angular.module('openshiftConsoleTemplates', []).run(['$templateCache', function(
1228312293
"</span>\n" +
1228412294
"<span ng-switch-when=\"deleted\">\n" +
1228512295
"<span class=\"pficon pficon-warning-triangle-o\" aria-hidden=\"true\"></span>\n" +
12286-
"<span>Marked for Deletion</span>\n" +
12296+
"Marked for Deletion\n" +
1228712297
"</span>\n" +
1228812298
"<span ng-switch-when=\"pending\">\n" +
1228912299
"<span class=\"spinner spinner-xs spinner-inline\" aria-hidden=\"true\"></span>\n" +
@@ -12352,7 +12362,7 @@ angular.module('openshiftConsoleTemplates', []).run(['$templateCache', function(
1235212362
"<span class=\"pficon pficon-warning-triangle-o\" aria-hidden=\"true\"></span>\n" +
1235312363
"<span class=\"sr-only\">warning</span>\n" +
1235412364
"<span class=\"strong\">The service was marked for deletion</span>\n" +
12355-
"<span class=\"strong\" am-time-ago=\"row.apiObject.metadata.deletionTimestamp\"></span>\n" +
12365+
"<span class=\"strong\" am-time-ago=\"row.apiObject.metadata.deletionTimestamp\"></span>.\n" +
1235612366
"</div>\n" +
1235712367
"</div>\n" +
1235812368
"</div>\n" +
@@ -12411,7 +12421,8 @@ angular.module('openshiftConsoleTemplates', []).run(['$templateCache', function(
1241112421
"</div>\n" +
1241212422
"<div class=\"col-sm-7 col-md-6 overview-bindings\">\n" +
1241312423
"<span ng-if=\"binding.metadata.deletionTimestamp\">\n" +
12414-
"<status-icon status=\"'Pending'\"></status-icon> Deleting\n" +
12424+
"<span class=\"pficon pficon-warning-triangle-o\" aria-hidden=\"true\"></span>\n" +
12425+
"Marked for Deletion\n" +
1241512426
"</span>\n" +
1241612427
"<span ng-if=\"!(binding | isBindingReady) && !binding.metadata.deletionTimestamp\">\n" +
1241712428
"<status-icon status=\"'Pending'\"></status-icon> Pending\n" +

0 commit comments

Comments
 (0)