Skip to content

konflux: update the mirrors file to take 1.12 builds into account#2276

Open
littlejawa wants to merge 1 commit into
openshift:develfrom
littlejawa:add_1.12_components_to_mirror
Open

konflux: update the mirrors file to take 1.12 builds into account#2276
littlejawa wants to merge 1 commit into
openshift:develfrom
littlejawa:add_1.12_components_to_mirror

Conversation

@littlejawa

@littlejawa littlejawa commented Jun 3, 2026

Copy link
Copy Markdown
Contributor

Fixes: KATA-5167

NOTE: this is actually needed on the 1.12 branch, but having both mirrors mentioned here will help for testing (no need to choose which mirror file to use).
I will pick this on the branch after it's merged, so that the Konflux automation running there can find and use this mirror.

Signed-off-by: Julien Ropé <jrope@redhat.com>
@coderabbitai

coderabbitai Bot commented Jun 3, 2026

Copy link
Copy Markdown

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited)

Review profile: CHILL

Plan: Enterprise

Run ID: 8bf1cc2b-ab06-4f68-944d-7e523ef4ade6

📥 Commits

Reviewing files that changed from the base of the PR and between 2dd2753 and db66b09.

📒 Files selected for processing (1)
  • .tekton/images-mirror-set.yaml

📝 Walkthrough

Walkthrough

This PR extends the image mirror set configuration by adding -v1-12 destination image mirror entries for OSC components. Both the tag-based and digest-based mirror sections are updated with parallel entries for images such as osc-monitor, osc-caa, osc-operator, and others, enabling mirroring of versioned image variants alongside the existing base mirror entries.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~5 minutes

🚥 Pre-merge checks | ✅ 14 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Microshift Test Compatibility ⚠️ Warning Test "should attempt to fetch from cluster" uses ClusterVersion (config.openshift.io/v1 API), unavailable on MicroShift, without [Skipped:MicroShift], [apigroup:], or IsMicroShiftCluster() protection. Add [apigroup:config.openshift.io] tag, [Skipped:MicroShift] label, or guard with IsMicroShiftCluster() check.
✅ Passed checks (14 passed)
Check name Status Explanation
Title check ✅ Passed The title accurately summarizes the main change: updating the mirrors file to support 1.12 builds, which is confirmed by the raw summary showing additions of '-v1-12' destination image mirror entries.
Description check ✅ Passed The description is directly related to the changeset, explaining why the mirrors file was updated (to support 1.12 builds) and providing context about the backport plan and associated Jira ticket.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Stable And Deterministic Test Names ✅ Passed PR modifies only .tekton/images-mirror-set.yaml (YAML config), with no changes to test files or Ginkgo test definitions, making the test name stability check inapplicable.
Test Structure And Quality ✅ Passed PR adds YAML and supporting files. Test code follows quality guidelines: single-responsibility tests, proper BeforeEach/AfterEach, meaningful assertion messages, and codebase consistency.
Single Node Openshift (Sno) Test Compatibility ✅ Passed PR modifies only .tekton/images-mirror-set.yaml, a YAML configuration file; no Ginkgo e2e tests are added, so SNO test compatibility check does not apply.
Topology-Aware Scheduling Compatibility ✅ Passed PR only modifies .tekton/images-mirror-set.yaml (image mirror configuration), not deployment, operator, or controller files. No scheduling constraints introduced.
Ote Binary Stdout Contract ✅ Passed This is a Kubernetes operator project, not an OTE test binary. The OTE Binary Stdout Contract check applies only to test binaries; this runs as a cluster controller manager.
Ipv6 And Disconnected Network Test Compatibility ✅ Passed PR only modifies .tekton/images-mirror-set.yaml (Tekton configuration), not test files. No Ginkgo e2e tests are added, so IPv6/disconnected network check does not apply.
No-Weak-Crypto ✅ Passed YAML configuration file for image mirrors contains no weak cryptography (MD5, SHA1, DES, RC4, 3DES, Blowfish, ECB), custom crypto implementations, or secret comparisons.
Container-Privileges ✅ Passed File contains only image mirror registry mappings with no container/pod definitions or privilege escalation markers (privileged, hostPID/Network/IPC, SYS_ADMIN, allowPrivilegeEscalation).
No-Sensitive-Data-In-Logs ✅ Passed The PR modifies only .tekton/images-mirror-set.yaml with container registry mirror configurations. No logging code, passwords, tokens, API keys, PII, or sensitive data are present in the changes.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

@openshift-ci openshift-ci Bot requested review from c3d and tbuskey June 3, 2026 15:51
@openshift-ci

openshift-ci Bot commented Jun 3, 2026

Copy link
Copy Markdown

@littlejawa: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant