sqlmesh: small fixes to business logic and date handling #3019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
ccerv1
commented
Feb 11, 2025
ccerv1
commented
- fix(sqlmesh): update onchain models to latest business logic
- fix(sqlmesh): include AA event types
- fix(sqlmesh): update project graphs to latest models
- fix(sqlmesh): final review and trino compatibility checks
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
ccerv1
temporarily deployed
to
external-prs-app
GitHub Actions
Inactive
![oso-prs[bot]](https://avatars.githubusercontent.com/in/856587?s=60&v=4){kind=small}
ccerv1
temporarily deployed
to
external-prs-app
GitHub Actions
Inactive
ryscheng
reviewed
Feb 12, 2025
There was a problem hiding this comment.
I think we discussed this at length yesterday, but a summary of what I remember:
- Let's version definitions with explicit dates so that we know what we funded
- I'll work on adding the events we discussed into the event table, so that we can write these models on top of the event table
- We will need to add user AA events into the event table as well, will need your help when we get to that point
- Worth doing a simple token transfer event into the event table as an example
- Eventually, we will need to track funding amounts to a metric_id / metric definition, which is why we probably want to have immutable definitions at the time of funding
- Otherwise looks fine, I'd keep running
| @@ -15,7 +14,7 @@ with developers as ( | |||
| on events.from_artifact_id = users.user_id | |||
| where | |||
| events.event_type = 'COMMIT_CODE' | |||
| and not regexp_matches( -- TODO: confirm this will work in Trino too | |||
There was a problem hiding this comment.
I don't think so...
https://trino.io/docs/current/functions/regexp.html
Can you
- Replace with valid regexp fn
- Make Trino dialect explicit in model definition
- Test with local Trino?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.