Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sqlmesh_project op succeeds even when assets fails to materialize #3032

Open
IcaroG opened this issue Feb 12, 2025 · 1 comment
Open

sqlmesh_project op succeeds even when assets fails to materialize #3032

IcaroG opened this issue Feb 12, 2025 · 1 comment
Assignees

Comments

@IcaroG
Copy link
Contributor

IcaroG commented Feb 12, 2025

To Reproduce

Trigger a run of materialize_core_assets_job on dagster.

Describe the Bug

When running materialize_core_assets_job, the sqlmesh_project op can be marked as succeeded even when some internal assets calculation was skipped/failed.

Image

I believe this state usually happens when the job is interrupted while materializing some of the assets (for example because another step failed), and when dagster doesn't restart from the correct place when running the retry.

Expected Behavior

We should detect missing assets materialization and fail the job in this case, to trigger a retry or notification to us.

Copy link

linear bot commented Feb 12, 2025

@github-project-automation github-project-automation bot moved this to Backlog in OSO Feb 12, 2025
@IcaroG IcaroG self-assigned this Feb 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Backlog
Development

No branches or pull requests

1 participant