Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Multi Language Support for LocationPickerView Entries #870

Open
2 of 3 tasks
ndegwamartin opened this issue May 26, 2022 · 0 comments
Open
2 of 3 tasks

Multi Language Support for LocationPickerView Entries #870

ndegwamartin opened this issue May 26, 2022 · 0 comments
Assignees
@qiarie

Comments

@ndegwamartin
Copy link
Contributor

ndegwamartin commented May 26, 2022 •
edited by qiarie
Loading

The former implementation of MLS support on location picker breaks apps that do not have translations. We need to refactor/fix the implementation to be backward compatible.

Acceptance criteria:

  • Support for Multi language translation - Location Picker should show any translated locations in the context language
  • Backward compatibility - Projects without translations should render the locations correctly
  • Unit tests for the above cases
ndegwamartin added a commit that referenced this issue May 26, 2022
@ndegwamartin
Revert Location translations
d68571d 
- Revert the translation locations #870
@ndegwamartin ndegwamartin mentioned this issue May 26, 2022
Merged
13 tasks
@qiarie qiarie self-assigned this May 27, 2022
ndegwamartin added a commit that referenced this issue May 30, 2022
@ndegwamartin
Revert Location translations
244bdbe 
- Revert the translation locations #870
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@qiarie qiarie

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@qiarie @ndegwamartin