Skip to content

Conversation

@kstrenkova
Copy link
Contributor

There is a relatively new parameter added to test-operator, called TimingDataUrl. We are trying to make the parameter work with jobs, but the issue is that there is no variable that stores the final Tempest pod name that will be created. Without it, we cannot build the timing data url, as we are saving the data under job/test-name folder.

This change adds a way to build the final url for both tests with and without workflow.

@kstrenkova kstrenkova force-pushed the build-tempest-timing-data-url branch from bd07a3f to 490b7d6 Compare October 1, 2025 09:29
@kstrenkova
Copy link
Contributor Author

@danpawlik Thank you for the review! It was very helpful, I even noticed one mistake I did in the logic. If you have any doubts please add comments again. It can be even nitpicks, as I am not very well versed in ansible yet I would like to learn from my mistakes :D.

Copy link
Contributor

@danpawlik danpawlik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks much better. Thank you.
I will take a look later in logs how it is working.

@kstrenkova kstrenkova force-pushed the build-tempest-timing-data-url branch from 490b7d6 to ce945f6 Compare October 14, 2025 09:11
@kstrenkova kstrenkova force-pushed the build-tempest-timing-data-url branch from ce945f6 to c835027 Compare October 21, 2025 13:36
@kstrenkova kstrenkova force-pushed the build-tempest-timing-data-url branch from c835027 to 4642758 Compare October 21, 2025 13:41
@kstrenkova kstrenkova force-pushed the build-tempest-timing-data-url branch from 4642758 to ae6544a Compare October 22, 2025 11:24
@kstrenkova
Copy link
Contributor Author

Tested in testproject 1484 (not sure if I can paste internal links here). I would appreciate your reviews again @sdatko and @danpawlik, now that the code should work as expected in all scenarios:

  1. When not using workflow, just set the timing data url directly in CR.
  2. Timing data url in main section gets propagated to workflow steps.
  3. If timing data url is directly in one step it is only added there and other steps are not affected.
  4. No timing data url anywhere, no change.

There is a relatively new parameter added to test-operator, called
TimingDataUrl. We are trying to make the parameter work with jobs,
but the issue is that there is no variable that stores the final
Tempest pod name that will be created. Without it, we cannot build
the timing data url, as we are saving the data under job/test-name
folder.

This change adds a way to build the final url for both tests with
and without workflow.
@kstrenkova kstrenkova force-pushed the build-tempest-timing-data-url branch from 9d5dcd8 to 5d8eeb1 Compare October 29, 2025 11:23
Copy link
Contributor

@sdatko sdatko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Oct 29, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: sdatko

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sdatko
Copy link
Contributor

sdatko commented Oct 29, 2025

Looks good to me, thanks!

@kstrenkova kstrenkova merged commit 1ea6b9c into openstack-k8s-operators:main Oct 30, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants