Add warning about NodeSet updates with OSDP failures

When a NodeSet is updated while it is associated with a failing OSDPD,
we will update the NodeSet but NOT update the Ansible inventory. This change adds
a warning for users so that they are aware of the fact that the OSDPD needs to be
deleted before the Ansible inventory will be updated.

Jira: OSPRH-15668
Signed-off-by: Brendan Shephard <[email protected]>

Author: bshephar

apis/dataplane/v1beta1/openstackdataplanenodeset_webhook.go

@@ -198,6 +198,17 @@ func (r *OpenStackDataPlaneNodeSet) ValidateUpdate(old runtime.Object) (admissio
 			}
 		}
 	}
+	if oldNodeSet.Status.DeploymentStatuses != nil {
+		for deployName, deployConditions := range oldNodeSet.Status.DeploymentStatuses {
+			deployCondition := deployConditions.Get(NodeSetDeploymentReadyCondition)
+			if !deployConditions.IsTrue(NodeSetDeploymentReadyCondition) && condition.IsError(deployCondition) {
+				return admission.Warnings{
+					fmt.Sprintf(`the NodeSet has been updated, but there is a failing OpenStackDataPlaneDeployment in the cluster: %s
+						    This will block updates to the Ansible inventory until the failing deployment has been deleted.`, deployName),
+				}, nil
+			}
+		}
+	}
 
 	return nil, nil
 }