Skip to content

Commit bc7d730

Browse files
committed
Bump tox tests to python 3.12
Upstream master now supports python 3.10 to python 3.12. The requirements can't be satisfied for 3.9 anymore, so bump the tox workflow to 3.12. With the higher version of python, bumps to flake8 and pylint were needed as well. Pylint added some new checks it seems. Those that report errors at the moment are disabled. One line was exactly 80 character long. I shortened it to pass the <= 79 character length check.
1 parent 82331da commit bc7d730

File tree

3 files changed

+23
-4
lines changed

3 files changed

+23
-4
lines changed

.github/workflows/toxjobs.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ jobs:
99
runs-on: ubuntu-latest
1010
strategy:
1111
matrix:
12-
python-version: ['3.9']
12+
python-version: ['3.12']
1313
steps:
1414
- uses: actions/checkout@v3
1515
- name: Set up Python ${{ matrix.python-version }}

.pre-commit-config.yaml

Lines changed: 21 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ repos:
1212
- id: check-yaml
1313
files: .*\.(yaml|yml)$
1414
- repo: https://github.com/pycqa/flake8.git
15-
rev: 3.9.0
15+
rev: 7.3.0
1616
hooks:
1717
- id: flake8
1818
- repo: https://github.com/openstack-dev/bashate.git
@@ -28,6 +28,25 @@ repos:
2828
# use jinja templating, this will often fail and the syntax
2929
# error will be discovered in execution anyway)
3030
- repo: https://github.com/PyCQA/pylint
31-
rev: pylint-2.7.2
31+
rev: v3.3.8
3232
hooks:
3333
- id: pylint
34+
args:
35+
[
36+
"--disable=C0209,R0917,R1705,R1734,R1735,W1514,W3301"
37+
]
38+
# C0209: Formatting a regular string which could be an
39+
# f-string (consider-using-f-string)
40+
# R0917: Too many positional arguments (25/5)
41+
# (too-many-positional-arguments)
42+
# R1705: Unnecessary "else" after "return", remove the "else"
43+
# and de-indent the code inside it (no-else-return)
44+
# R1734: Consider using [] instead of list() (use-list-literal)
45+
# R1753: Consider using '{}' instead of a call to 'dict'.
46+
# (use-dict-literal)
47+
# W1514: Using open without explicitly specifying
48+
# an encoding (unspecified-encoding)
49+
# W3301: Do not use nested call of 'min'; it's possible to do
50+
# 'min(8, max(2, processutils.get_worker_count()),
51+
# len(containers))'
52+
# instead (nested-min-max)

tcib/client/utils.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -59,7 +59,7 @@ class TempDirs(object):
5959

6060
def __init__(self, dir_path=None, dir_prefix='tcib', cleanup=True,
6161
chdir=True):
62-
"""This context manager will create, push, and cleanup temp directories.
62+
"""This context manager will create, push and cleanup temp directories.
6363
>>> with TempDirs() as t:
6464
... with open('file', 'w') as f:
6565
... f.write('test')

0 commit comments

Comments
 (0)