Failing E2E tests

[thewhaleking]

Yesterday, the e2e failed blocking the release of async-substrate-interface 1.5.2 to investigate:
https://github.com/opentensor/async-substrate-interface/actions/runs/16985974321/job/48154910075?pr=180

The following failures occurred:

• bittensor/tests/e2e_tests/test_subtensor_functions.py
• bittensor/tests/e2e_tests/test_staking.py
• bittensor/tests/e2e_tests/test_commit_reveal_v3.py

This morning, I reviewed the PR #3016, in which I noticed 13 failed e2e tests, on a PR which simply updated a type annotation.
Failures:

• tests/e2e_tests/test_commit_reveal_v3.py [3.9, 3.12, 3.13]
• tests/e2e_tests/test_staking.py [3.9, 3.10, 3.11, 3.12, 3.13]
• tests/e2e_tests/test_subtensor_functions.py [3.9, 3.10, 3.11, 3.12, 3.13]

I opened #3018 (a no-op PR) to run the tests, and had 11 failed e2e tests:

• tests/e2e_tests/test_commit_reveal_v3.py [3.9]
• tests/e2e_tests/test_staking.py [3.9, 3.10, 3.11, 3.12, 3.13]
• tests/e2e_tests/test_subtensor_functions.py [3.9, 3.10, 3.11, 3.12, 3.13]

We've known about the flakiness of test_commit_reveal_v3 for at least a few days (see: #3015).

But the others appear new.

[thewhaleking]

All of these failures occurred using the ghcr.io/opentensor/subtensor-localnet:devnet-ready image

[thewhaleking]

Confirmed that the breakages are due to devnet-ready image by running opentensor/async-substrate-interface#180 with main image

Still failures using main image.

test_subtensor_extrinsics
E       AssertionError: Balance for Bob is not correct after burned register
E       assert (τ1,000,000.000000000 - τ0.100000000) == τ999,999.899704281

test_batch_operations
>       assert balances == expected_balances
E       AssertionError: assert {'5FHneW46xGX...435.891587425} == {'5FHneW46xGX...435.891587425}
E         
E         Omitting 1 identical items, use -vv to show
E         Differing items:
E         {'5FHneW46xGXgs5mUiveU4sbTyGBzmstUspZC92UhjJM694ty': τ999,999.799408562} != {'5FHneW46xGXgs5mUiveU4sbTyGBzmstUspZC92UhjJM694ty': τ999,999.800000000}
E         
E         Full diff:
E           {
E         -     '5FHneW46xGXgs5mUiveU4sbTyGBzmstUspZC92UhjJM694ty': τ999,999.800000000,
E         ?                                                                   ^^^^^^^^
E         +     '5FHneW46xGXgs5mUiveU4sbTyGBzmstUspZC92UhjJM694ty': τ999,999.799408562,
E         ?                                                                  +++++ ^^^
E               '5GrwvaEF5zXb26Fz9rcQpDWS57CtERHpNehXCPcNoHGKutQY': τ988,435.891587425,
E           }

[thewhaleking]

The issue is that we're not calculating the new extrinsic fee.

[thewhaleking]

See #3020

[thewhaleking]

Seems test_liquidity is flaky aswell:

E       AssertionError: Subtensor returned `InsufficientBalance(Module)` error. This means: `The caller does not have enough balance for the operation. | Please consult [https://docs.bittensor.com/errors/subtensor#insufficientbalance`.](https://docs.bittensor.com/errors/subtensor#insufficientbalance%60.)
  E       assert False

Added to #3015

[basfroman]

fixed