Refactor set with

[t2gran]

Summary

100% pure refactoring of Bulder setX to Builder withX. This changes all reminding builders to follow the current naming conventions.

Issue

This was not done for AStarBuilder in #6888, where this issue where raised as part of the review.

Unit tests

🟥 The code is not changed, except deleting on unused method and renaming builder methods.

Documentation

🟥 Not relevant

Changelog

🟥 Not relevant

Bumping the serialization version id

🟥 Not needed

[codecov]

Codecov Report

❌ Patch coverage is 80.24691% with 16 lines in your changes missing coverage. Please review.
✅ Project coverage is 72.10%. Comparing base (cc6c6c6) to head (aae466d).
⚠️ Report is 52 commits behind head on dev-2.x.

Files with missing lines	Patch %	Lines
...oradapter/transit/mappers/RaptorRequestMapper.java	0.00%	7 Missing ⚠️
...mapping/routerequest/LegacyRouteRequestMapper.java	71.42%	2 Missing ⚠️
...nner/apis/transmodel/mapping/ViaSegmentMapper.java	0.00%	2 Missing ⚠️
...ner/apis/transmodel/mapping/TripRequestMapper.java	50.00%	1 Missing ⚠️
...ing/api/request/preference/TransitPreferences.java	0.00%	1 Missing ⚠️
.../opentripplanner/routing/impl/GraphPathFinder.java	88.88%	1 Missing ⚠️
...rg/opentripplanner/visualizer/GraphVisualizer.java	0.00%	1 Missing ⚠️
...lanner/raptor/api/request/DebugRequestBuilder.java	0.00%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             dev-2.x    #6919   +/-   ##
==========================================
  Coverage      72.10%   72.10%           
  Complexity     19660    19660           
==========================================
  Files           2124     2124           
  Lines          79507    79505    -2     
  Branches        8050     8050           
==========================================
  Hits           57326    57326           
+ Misses         19344    19342    -2     
  Partials        2837     2837           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[jessicaKoehnke]

Which "current naming conventions" are you referring to? Conventions in OTP or in Java in general?
Edit: I just saw there is an ADR in OTP saying to use with.

[leonardehrenfried]

For others that wonder: https://github.com/opentripplanner/OpenTripPlanner/blob/dev-2.x/doc/dev/decisionrecords/NamingConventions.md