feat: svg improve (#543)

svg improve
- [x] svg refactor & fix 
- [x] rect
- [x] defs
- [x] linearGradient
- [x] stop
- [x] clipPath
- [x] svg support scale by width/height

Author: andycall

.github/workflows/integration_test_flutter.yml

@@ -5,7 +5,7 @@ on: [workflow_dispatch, pull_request]
 env:
   nodeVersion: "16"
   cmakeVersion: "3.22.x"
-  flutter310: "3.13.5"
+  flutter: "3.19.3"
 
 # A workflow run is made up of one or more jobs that can run sequentially or in parallel
 jobs:
@@ -67,7 +67,7 @@ jobs:
         submodules: recursive
     - uses: subosito/flutter-action@v2
       with:
-        flutter-version: ${{ env.flutter310 }}
+        flutter-version: ${{ env.flutter }}
     - run: flutter config --enable-macos-desktop
     - run: flutter doctor -v
     - run: cd webf && flutter test
@@ -88,7 +88,7 @@ jobs:
         node-version: ${{ env.nodeVersion }}
     - uses: subosito/flutter-action@v2
       with:
-        flutter-version: ${{ env.flutter310 }}
+        flutter-version: ${{ env.flutter }}
     - run: flutter config --enable-macos-desktop
     - run: flutter doctor -v
     - uses: actions/download-artifact@v2
@@ -124,11 +124,11 @@ jobs:
         path: bridge/build/macos/
     - uses: subosito/flutter-action@v2
       with:
-        flutter-version: ${{ env.flutter310 }}
+        flutter-version: ${{ env.flutter }}
     - run: flutter config --enable-macos-desktop
     - run: flutter doctor -v
     - name: Run MultiplePageTest Test
-      run: cd integration_tests && npm run multiple_page_test
+      run: cd integration_tests && LOAD_MODE=prerendering node scripts/preload_prerendering_page_integration.js
       id: test
       continue-on-error: true
     - name: Check on failures
@@ -151,7 +151,7 @@ jobs:
         path: bridge/build/macos/
     - uses: subosito/flutter-action@v2
       with:
-        flutter-version: ${{ env.flutter310 }}
+        flutter-version: ${{ env.flutter }}
     - run: flutter config --enable-macos-desktop
     - run: flutter doctor -v
     - name: Run MultiplePageTest Test
@@ -177,7 +177,7 @@ jobs:
         path: bridge/build/macos/
     - uses: subosito/flutter-action@v2
       with:
-        flutter-version: ${{ env.flutter310 }}
+        flutter-version: ${{ env.flutter }}
     - run: flutter config --enable-macos-desktop
     - run: flutter doctor -v
     - name: Run MultiplePageTest Test
@@ -204,7 +204,7 @@ jobs:
         path: bridge/build/macos/
     - uses: subosito/flutter-action@v2
       with:
-        flutter-version: ${{ env.flutter310 }}
+        flutter-version: ${{ env.flutter }}
     - run: flutter config --enable-macos-desktop
     - run: flutter doctor -v
     - name: Run MemoryLeak Test

bridge/foundation/shared_ui_command.cc

@@ -70,11 +70,17 @@ void SharedUICommand::SyncToReserve() {
   if (waiting_buffer_->empty())
     return;
 
+  size_t waiting_size = waiting_buffer_->size();
+  size_t origin_reserve_size = reserve_buffer_->size();
+
   if (reserve_buffer_->empty()) {
-    swap(waiting_buffer_, reserve_buffer_);
+    swap(reserve_buffer_, waiting_buffer_);
   } else {
     appendCommand(reserve_buffer_, waiting_buffer_);
   }
+
+  assert(waiting_buffer_->empty());
+  assert(reserve_buffer_->size() == waiting_size + origin_reserve_size);
 }
 
 void SharedUICommand::ConfigureSyncCommandBufferSize(size_t size) {
@@ -84,33 +90,33 @@ void SharedUICommand::ConfigureSyncCommandBufferSize(size_t size) {
 void SharedUICommand::SyncToActive() {
   SyncToReserve();
 
+  assert(waiting_buffer_->empty());
+
   if (reserve_buffer_->empty())
     return;
 
   ui_command_sync_strategy_->Reset();
   context_->dartMethodPtr()->requestBatchUpdate(context_->isDedicated(), context_->contextId());
 
-  if (active_buffer->empty()) {
-    swap(reserve_buffer_, active_buffer);
-  } else {
-    appendCommand(reserve_buffer_, active_buffer);
-  }
+  size_t reserve_size = reserve_buffer_->size();
+  size_t origin_active_size = active_buffer->size();
+  appendCommand(active_buffer, reserve_buffer_);
+  assert(reserve_buffer_->empty());
+  assert(active_buffer->size() == reserve_size + origin_active_size);
 }
 
-void SharedUICommand::swap(std::unique_ptr<UICommandBuffer>& original, std::unique_ptr<UICommandBuffer>& target) {
+void SharedUICommand::swap(std::unique_ptr<UICommandBuffer>& target, std::unique_ptr<UICommandBuffer>& original) {
   is_blocking_writing_.store(true, std::memory_order::memory_order_release);
   std::swap(target, original);
   is_blocking_writing_.store(false, std::memory_order::memory_order_release);
 }
 
-void SharedUICommand::appendCommand(std::unique_ptr<UICommandBuffer>& original,
-                                    std::unique_ptr<UICommandBuffer>& target) {
+void SharedUICommand::appendCommand(std::unique_ptr<UICommandBuffer>& target,
+                                    std::unique_ptr<UICommandBuffer>& original) {
   is_blocking_writing_.store(true, std::memory_order::memory_order_release);
 
-  for (int i = 0; i < original->size(); i++) {
-    UICommandItem* command_item = original->data();
-    target->addCommand(command_item[i]);
-  }
+  UICommandItem* command_item = original->data();
+  target->addCommands(command_item, original->size());
 
   original->clear();
 

bridge/foundation/ui_command_buffer.cc

@@ -86,6 +86,28 @@ void UICommandBuffer::addCommand(const UICommandItem& item, bool request_ui_upda
   size_++;
 }
 
+void UICommandBuffer::addCommands(const webf::UICommandItem* items, int64_t item_size, bool request_ui_update) {
+  if (UNLIKELY(!context_->dartIsolateContext()->valid())) {
+    return;
+  }
+
+  int64_t target_size = size_ + item_size;
+  if (target_size > max_size_) {
+    buffer_ = (UICommandItem*)realloc(buffer_, sizeof(UICommandItem) * target_size * 2);
+    max_size_ = target_size * 2;
+  }
+
+#if FLUTTER_BACKEND
+  if (UNLIKELY(request_ui_update && !update_batched_ && context_->IsContextValid())) {
+    context_->dartMethodPtr()->requestBatchUpdate(context_->isDedicated(), context_->contextId());
+    update_batched_ = true;
+  }
+#endif
+
+  std::memcpy(buffer_ + size_, items, sizeof(UICommandItem) * item_size);
+  size_ = target_size;
+}
+
 UICommandItem* UICommandBuffer::data() {
   return buffer_;
 }

bridge/foundation/ui_command_buffer.h

@@ -83,6 +83,7 @@ class UICommandBuffer {
 
  private:
   void addCommand(const UICommandItem& item, bool request_ui_update = true);
+  void addCommands(const UICommandItem* items, int64_t item_size, bool request_ui_update = true);
   void updateFlags(UICommand command);
 
   ExecutingContext* context_{nullptr};

integration_tests/scripts/core_integration_starter.js

@@ -17,7 +17,7 @@ function startIntegrationTest() {
   const shouldSkipBuild = /skip\-build/.test(process.argv);
   if (!shouldSkipBuild) {
     console.log('Building integration tests macOS application from "lib/main.dart"...');
-    spawnSync('flutter', ['build', getRunningPlatform(), '--profile'], {
+    spawnSync('flutter', ['build', getRunningPlatform(), '--debug'], {
       stdio: 'inherit'
     });
   }
@@ -27,9 +27,9 @@ function startIntegrationTest() {
   if (platform === 'linux') {
     testExecutable = path.join(__dirname, '../build/linux/x64/debug/bundle/app');
   } else if (platform === 'darwin') {
-    testExecutable = path.join(__dirname, '../build/macos/Build/Products/Profile/tests.app/Contents/MacOS/tests');
+    testExecutable = path.join(__dirname, '../build/macos/Build/Products/Debug/tests.app/Contents/MacOS/tests');
   } else if (platform == 'win32') {
-    testExecutable = path.join(__dirname, '../build/windows/runner/Profile/app.exe');
+    testExecutable = path.join(__dirname, '../build/windows/runner/Debug/app.exe');
   } else {
     throw new Error('Unsupported platform:' + platform);
   }