Skip to content

Commit 8a99b0f

Browse files
authored
Merge pull request #944 from drdrew42/primary-key-pgfile-keyword
Ensure all OPL tables have primary keys
2 parents b659dc7 + acc7935 commit 8a99b0f

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

Diff for: .github/workflows/bin/generate-OPL-tables.pl

+4-4
Original file line numberDiff line numberDiff line change
@@ -145,7 +145,7 @@ sub dbug {
145145
$tables{pgfile_keyword}, '
146146
pgfile_id int(15) DEFAULT 0 NOT NULL,
147147
keyword_id int(15) DEFAULT 0 NOT NULL,
148-
KEY pgfile_keyword (keyword_id, pgfile_id),
148+
PRIMARY KEY pgfile_keyword (keyword_id, pgfile_id),
149149
KEY pgfile (pgfile_id)'
150150
],
151151
[
@@ -537,7 +537,7 @@ sub pgfiles {
537537
);
538538
if (not $DBsubject_id) {
539539
print "\nInvalid subject '$tags->{DBsubject}' in $name\n";
540-
next;
540+
return;
541541
}
542542

543543
# DBchapter table
@@ -549,7 +549,7 @@ sub pgfiles {
549549
);
550550
if (not $DBchapter_id) {
551551
print "\nInvalid chapter '$tags->{DBchapter}' in $name\n";
552-
next;
552+
return;
553553
}
554554

555555
# DBsection table
@@ -561,7 +561,7 @@ sub pgfiles {
561561
);
562562
if (!$aDBsection_id) {
563563
print "\nInvalid section '$tags->{DBsection}' in $name\n";
564-
next;
564+
return;
565565
}
566566
} else {
567567
# Tags are not valid, error printed by validation part.

0 commit comments

Comments
 (0)