Skip to content

Commit ffbf321

Browse files
author
Per Goncalves da Silva
committed
test
Signed-off-by: Per Goncalves da Silva <[email protected]>
1 parent 13de323 commit ffbf321

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

test/e2e/steps/steps.go

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -310,13 +310,13 @@ func ClusterExtensionResourcesCreatedAndAreLabeled(ctx context.Context) error {
310310
kind := obj.GetObjectKind().GroupVersionKind().Kind
311311
clusterObj, err := getResource(kind, obj.GetName(), obj.GetNamespace())
312312
if err != nil {
313-
logger.V(1).Info("error getting resource name=%q namespace=%q kind=%q: %v", obj.GetName(), obj.GetNamespace(), kind, err)
313+
logger.V(1).Error(err, "error getting resource", "name", obj.GetName(), "namespace", obj.GetNamespace(), "kind", kind)
314314
return false
315315
}
316316

317317
labels := clusterObj.GetLabels()
318318
if labels == nil {
319-
logger.V(1).Info("resource name=%q namespace=%q kind=%q has no labels", obj.GetName(), obj.GetNamespace(), kind)
319+
logger.V(1).Info("no labels found for resource", "name", obj.GetName(), "namespace", obj.GetNamespace(), "kind", kind)
320320
return false
321321
}
322322

@@ -325,7 +325,7 @@ func ClusterExtensionResourcesCreatedAndAreLabeled(ctx context.Context) error {
325325
"olm.operatorframework.io/owner-name": sc.clusterExtensionName,
326326
} {
327327
if labels[key] != expectedValue {
328-
logger.V(1).Info("resource name=%q namespace=%q kind=%q expected label %q to equal %q but got %q", obj.GetName(), obj.GetNamespace(), kind, key, expectedValue, labels["olm.operatorframework.io/owner-kind"])
328+
logger.V(1).Info("invalid resource label value", "name", obj.GetName(), "namespace", obj.GetNamespace(), "kind", kind, "label", key, "expected", expectedValue, "actual", labels["olm.operatorframework.io/owner-kind"])
329329
return false
330330
}
331331
}

0 commit comments

Comments
 (0)