Skip to content

Commit a0ee87c

Browse files
committed
removed delegator support
1 parent 63423d8 commit a0ee87c

File tree

6 files changed

+0
-304
lines changed

6 files changed

+0
-304
lines changed

ramler-gradle-plugin/src/main/java/org/ops4j/ramler/gradle/AbstractRamlerJavaGenerator.java

-73
Original file line numberDiff line numberDiff line change
@@ -46,16 +46,8 @@ public abstract class AbstractRamlerJavaGenerator extends AbstractRamlerTask {
4646

4747
private boolean jacksonPropertyName;
4848

49-
/**
50-
*/
5149
private boolean jacksonUnion;
5250

53-
private boolean delegators;
54-
55-
private String delegatorSuffix;
56-
57-
private String delegateFieldName;
58-
5951
/**
6052
* Gets the fully qualified package name for generated Java sources. The generated classes will be
6153
* located in subpackages {@code model} and {@code api}.
@@ -181,68 +173,6 @@ public void setJacksonUnion(boolean jacksonUnion) {
181173
this.jacksonUnion = jacksonUnion;
182174
}
183175

184-
/**
185-
* Gets the delegators.
186-
*
187-
* @return the delegators
188-
*/
189-
@Input
190-
public boolean isDelegators() {
191-
return delegators;
192-
}
193-
194-
/**
195-
* Sets the delegators.
196-
*
197-
* @param delegators
198-
* the delegators to set
199-
*/
200-
public void setDelegators(boolean delegators) {
201-
this.delegators = delegators;
202-
}
203-
204-
/**
205-
* Gets the delegatorSuffix.
206-
*
207-
* @return the delegatorSuffix
208-
*/
209-
@Input
210-
@Optional
211-
public String getDelegatorSuffix() {
212-
return delegatorSuffix;
213-
}
214-
215-
/**
216-
* Sets the delegatorSuffix.
217-
*
218-
* @param delegatorSuffix
219-
* the delegatorSuffix to set
220-
*/
221-
public void setDelegatorSuffix(String delegatorSuffix) {
222-
this.delegatorSuffix = delegatorSuffix;
223-
}
224-
225-
/**
226-
* Gets the delegateFieldName.
227-
*
228-
* @return the delegateFieldName
229-
*/
230-
@Input
231-
@Optional
232-
public String getDelegateFieldName() {
233-
return delegateFieldName;
234-
}
235-
236-
/**
237-
* Sets the delegateFieldName.
238-
*
239-
* @param delegateFieldName
240-
* the delegateFieldName to set
241-
*/
242-
public void setDelegateFieldName(String delegateFieldName) {
243-
this.delegateFieldName = delegateFieldName;
244-
}
245-
246176
protected abstract String getDefaultOutputSubdir();
247177

248178
protected abstract String getSourceSet();
@@ -262,9 +192,6 @@ public void generate() {
262192
config.setJacksonTypeInfo(jacksonTypeInfo);
263193
config.setJacksonPropertyName(jacksonPropertyName);
264194
config.setJacksonUnion(jacksonUnion);
265-
config.setDelegators(delegators);
266-
config.setDelegateFieldName(delegateFieldName);
267-
config.setDelegatorSuffix(delegatorSuffix);
268195

269196
JavaPluginConvention javaPluginConvention = getProject().getConvention()
270197
.getPlugin(JavaPluginConvention.class);

ramler-java/src/main/java/org/ops4j/ramler/java/DelegatorGenerator.java

-151
This file was deleted.

ramler-java/src/main/java/org/ops4j/ramler/java/JavaConfiguration.java

-53
Original file line numberDiff line numberDiff line change
@@ -50,12 +50,6 @@ public class JavaConfiguration {
5050

5151
private boolean jacksonUnion;
5252

53-
private boolean delegators;
54-
55-
private String delegatorSuffix;
56-
57-
private String delegateFieldName;
58-
5953
/**
6054
* Gets the name of the base package for all subpackages created by the code generator.
6155
*
@@ -269,53 +263,6 @@ public void setJacksonPropertyName(boolean jacksonPropertyName) {
269263
this.jacksonPropertyName = jacksonPropertyName;
270264
}
271265

272-
/**
273-
* @return the delegators
274-
*/
275-
public boolean isDelegators() {
276-
return delegators;
277-
}
278-
279-
/**
280-
* @param delegators
281-
* the delegators to set
282-
*/
283-
public void setDelegators(boolean delegators) {
284-
this.delegators = delegators;
285-
}
286-
287-
/**
288-
* @return the delegatorSuffix
289-
*/
290-
public String getDelegatorSuffix() {
291-
return Optional.ofNullable(delegatorSuffix)
292-
.orElse("Delegator");
293-
}
294-
295-
/**
296-
* @param delegatorSuffix
297-
* the delegatorSuffix to set
298-
*/
299-
public void setDelegatorSuffix(String delegatorSuffix) {
300-
this.delegatorSuffix = delegatorSuffix;
301-
}
302-
303-
/**
304-
* @return the delegateFieldName
305-
*/
306-
public String getDelegateFieldName() {
307-
return Optional.ofNullable(delegateFieldName)
308-
.orElse("delegate");
309-
}
310-
311-
/**
312-
* @param delegateFieldName
313-
* the delegateFieldName to set
314-
*/
315-
public void setDelegateFieldName(String delegateFieldName) {
316-
this.delegateFieldName = delegateFieldName;
317-
}
318-
319266
/**
320267
* Should Jackson annotations {@code @JsonSerializer} etc. be used for union types?
321268
*

ramler-java/src/main/java/org/ops4j/ramler/java/PojoGeneratingApiVisitor.java

-21
Original file line numberDiff line numberDiff line change
@@ -80,8 +80,6 @@ public class PojoGeneratingApiVisitor implements ApiVisitor {
8080

8181
private EnumGenerator enumGenerator;
8282

83-
private DelegatorGenerator delegatorGenerator;
84-
8583
private UnionGenerator unionGenerator;
8684

8785
private NameFactory nameFactory;
@@ -97,7 +95,6 @@ public PojoGeneratingApiVisitor(JavaGeneratorContext context) {
9795
this.codeModel = context.getCodeModel();
9896
this.pkg = context.getModelPackage();
9997
this.enumGenerator = new EnumGenerator(context);
100-
this.delegatorGenerator = new DelegatorGenerator(context);
10198
this.unionGenerator = new UnionGenerator(context);
10299
this.nameFactory = new JavaNameFactory();
103100
}
@@ -117,29 +114,11 @@ public void visitObjectTypeStart(ObjectTypeDeclaration type) {
117114
addMixinProperties(klass, type);
118115
}
119116

120-
@Override
121-
public void visitObjectTypeEnd(ObjectTypeDeclaration type) {
122-
if (context.getConfig()
123-
.isDelegators()) {
124-
JDefinedClass klass = pkg._getClass(type.name());
125-
if (klass != null) {
126-
generateDelegator(klass);
127-
}
128-
}
129-
}
130-
131117
@Override
132118
public void visitUnionType(UnionTypeDeclaration type) {
133119
unionGenerator.generateUnionClass(type);
134120
}
135121

136-
/**
137-
* @param klass
138-
*/
139-
private void generateDelegator(JDefinedClass klass) {
140-
delegatorGenerator.generateDelegator(klass);
141-
}
142-
143122
private void addBaseClass(JDefinedClass klass, ObjectTypeDeclaration type) {
144123
TypeDeclaration parentType = type.parentTypes()
145124
.get(0);

ramler-java/src/test/java/org/ops4j/ramler/java/AbstractGeneratorTest.java

-3
Original file line numberDiff line numberDiff line change
@@ -30,8 +30,6 @@
3030
import org.junit.jupiter.api.BeforeAll;
3131
import org.junit.jupiter.api.TestInstance;
3232
import org.junit.jupiter.api.TestInstance.Lifecycle;
33-
import org.ops4j.ramler.java.JavaConfiguration;
34-
import org.ops4j.ramler.java.JavaGenerator;
3533

3634
import com.sun.codemodel.JAnnotationUse;
3735
import com.sun.codemodel.JAnnotationValue;
@@ -62,7 +60,6 @@ public void generateJavaModel() {
6260
config.setSourceFile(String.format("raml/%s.raml", getBasename()));
6361
config.setBasePackage(String.format("org.ops4j.raml.%s", getBasename()));
6462
config.setTargetDir(new File("target/generated/raml"));
65-
config.setDelegators(true);
6663
config.setJacksonUnion(true);
6764

6865
generator = new JavaGenerator(config);

ramler-maven-plugin/src/main/java/org/ops4j/ramler/maven/AbstractJavaMojo.java

-3
Original file line numberDiff line numberDiff line change
@@ -96,9 +96,6 @@ protected void generateOutput() throws MojoFailureException {
9696
config.setJacksonTypeInfo(jacksonTypeInfo);
9797
config.setJacksonPropertyName(jacksonPropertyName);
9898
config.setJacksonUnion(jacksonUnion);
99-
config.setDelegators(delegators);
100-
config.setDelegateFieldName(delegateFieldName);
101-
config.setDelegatorSuffix(delegatorSuffix);
10299

103100
try {
104101
JavaGenerator generator = new JavaGenerator(config);

0 commit comments

Comments
 (0)