fix: address review feedback on graph model

- getCallableNodes now queries all 10 CORE_SYMBOL_KINDS, not just 3
  (fixes function-level cycle detection regression for interfaces,
  structs, enums, traits, records, modules, types)
- edgeCount returns logical edge count for undirected graphs (was 2x)
- Remove duplicate branches in toGraphology

Author: carlos-alm

src/db/repository/graph-read.js

@@ -1,3 +1,4 @@
+import { CORE_SYMBOL_KINDS } from '../../kinds.js';
 import { cachedStmt } from './cached-stmt.js';
 
 // ─── Statement caches (one prepared statement per db instance) ────────────
@@ -6,16 +7,18 @@ const _getCallEdgesStmt = new WeakMap();
 const _getFileNodesAllStmt = new WeakMap();
 const _getImportEdgesStmt = new WeakMap();
 
+const CALLABLE_KINDS_SQL = CORE_SYMBOL_KINDS.map((k) => `'${k}'`).join(',');
+
 /**
- * Get callable nodes (function/method/class) for community detection.
+ * Get callable nodes (all core symbol kinds) for graph construction.
  * @param {object} db
  * @returns {{ id: number, name: string, kind: string, file: string }[]}
  */
 export function getCallableNodes(db) {
   return cachedStmt(
     _getCallableNodesStmt,
     db,
-    "SELECT id, name, kind, file FROM nodes WHERE kind IN ('function','method','class')",
+    `SELECT id, name, kind, file FROM nodes WHERE kind IN (${CALLABLE_KINDS_SQL})`,
   ).all();
 }
 

src/graph/model.js

@@ -32,7 +32,8 @@ export class CodeGraph {
   get edgeCount() {
     let count = 0;
     for (const targets of this._successors.values()) count += targets.size;
-    return count;
+    // Undirected graphs store each edge twice (a→b and b→a)
+    return this._directed ? count : count / 2;
   }
 
   // ─── Node operations ────────────────────────────────────────────
@@ -195,17 +196,9 @@ export class CodeGraph {
       g.addNode(id);
     }
 
-    if (type === 'undirected') {
-      // Deduplicate: only add each unordered pair once
-      for (const [src, tgt] of this.edges()) {
-        if (src === tgt) continue;
-        if (!g.hasEdge(src, tgt)) g.addEdge(src, tgt);
-      }
-    } else {
-      for (const [src, tgt] of this.edges()) {
-        if (src === tgt) continue;
-        if (!g.hasEdge(src, tgt)) g.addEdge(src, tgt);
-      }
+    for (const [src, tgt] of this.edges()) {
+      if (src === tgt) continue;
+      if (!g.hasEdge(src, tgt)) g.addEdge(src, tgt);
     }
     return g;
   }

tests/graph/model.test.js

@@ -94,8 +94,7 @@ describe('CodeGraph — undirected', () => {
     const g = new CodeGraph({ directed: false });
     g.addEdge('a', 'b');
     g.addEdge('b', 'c');
-    expect(g.edgeCount).toBe(4); // 2 directed entries per undirected edge
-    // But edges() iterator deduplicates
+    expect(g.edgeCount).toBe(2);
     expect([...g.edges()]).toHaveLength(2);
   });
 });