[FSSDK-11150] review update

Author: junaed-optimizely

OptimizelySDK/Cmab/CmabConstants.cs

@@ -27,5 +27,6 @@ internal static class CmabConstants
 
         public const string ErrorFetchFailedFmt = "CMAB decision fetch failed with status: {0}";
         public const string ErrorInvalidResponse = "Invalid CMAB fetch response";
+        public const string ExhaustRetryMessage = "Exhausted all retries for CMAB request";
     }
 }

OptimizelySDK/Cmab/DefaultCmabClient.cs

@@ -116,7 +116,6 @@ private async Task<string> DoFetchOnceAsync(string url, CmabRequest request, Tim
         {
             using (var cts = new CancellationTokenSource(timeout))
             {
-
                 try
                 {
                     var httpRequest = new HttpRequestMessage
@@ -179,8 +178,8 @@ private async Task<string> DoFetchWithRetryAsync(string url, CmabRequest request
                 {
                     if (attempt >= _retryConfig.MaxRetries)
                     {
-                        _logger.Log(LogLevel.ERROR, string.Format(CmabConstants.ErrorFetchFailedFmt, "Exhausted all retries for CMAB request."));
-                        throw new CmabFetchException(string.Format(CmabConstants.ErrorFetchFailedFmt, "Exhausted all retries for CMAB request."));
+                        _logger.Log(LogLevel.ERROR, string.Format(CmabConstants.ErrorFetchFailedFmt, CmabConstants.ExhaustRetryMessage));
+                        throw new CmabFetchException(string.Format(CmabConstants.ErrorFetchFailedFmt, CmabConstants.ExhaustRetryMessage));
                     }
 
                     _logger.Log(LogLevel.INFO, $"Retrying CMAB request (attempt: {attempt + 1}) after {backoff.TotalSeconds} seconds...");