Merge pull request #12 from optimizely/aliabbasrizvi/better_message

Improving log message for dispatching events

Author: aliabbasrizvi

src/Optimizely/Optimizely.php

@@ -215,7 +215,7 @@ public function activate($experimentKey, $userId, $attributes = null)
         $this->_logger->log(
             Logger::DEBUG,
             sprintf('Dispatching impression event to URL %s with params %s.',
-                $impressionEvent->getUrl(), implode(',', $impressionEvent->getParams())
+                $impressionEvent->getUrl(), http_build_query($impressionEvent->getParams())
             )
         );
 
@@ -290,7 +290,7 @@ public function track($eventKey, $userId, $attributes = null, $eventValue = null
             $this->_logger->log(
                 Logger::DEBUG,
                 sprintf('Dispatching conversion event to URL %s with params %s.',
-                    $conversionEvent->getUrl(), implode(',', $conversionEvent->getParams())
+                    $conversionEvent->getUrl(), http_build_query($conversionEvent->getParams())
                 ));
 
             try {

tests/OptimizelyTest.php

@@ -315,7 +315,7 @@ public function testActivateNoAudienceNoAttributes()
         $this->loggerMock->expects($this->at(5))
             ->method('log')
             ->with(Logger::DEBUG,
-                'Dispatching impression event to URL logx.optimizely.com/decision with params val1,val2.');
+                'Dispatching impression event to URL logx.optimizely.com/decision with params param1=val1&param2=val2.');
 
         $optlyObject = new Optimizely($this->datafile, new ValidEventDispatcher(), $this->loggerMock);
         $eventBuilder = new \ReflectionProperty(Optimizely::class, '_eventBuilder');
@@ -383,7 +383,7 @@ public function testActivateWithAttributes()
         $this->loggerMock->expects($this->at(3))
             ->method('log')
             ->with(Logger::DEBUG,
-                'Dispatching impression event to URL logx.optimizely.com/decision with params val1.');
+                'Dispatching impression event to URL logx.optimizely.com/decision with params param1=val1.');
 
         $optlyObject = new Optimizely($this->datafile, new ValidEventDispatcher(), $this->loggerMock);
 
@@ -555,7 +555,7 @@ public function testTrackNoAttributesNoEventValue()
         $this->loggerMock->expects($this->at(5))
             ->method('log')
             ->with(Logger::DEBUG,
-                'Dispatching conversion event to URL logx.optimizely.com/track with params val1.');
+                'Dispatching conversion event to URL logx.optimizely.com/track with params param1=val1.');
 
         $optlyObject = new Optimizely($this->datafile, new ValidEventDispatcher(), $this->loggerMock);
 
@@ -605,7 +605,7 @@ public function testTrackWithAttributesNoEventValue()
         $this->loggerMock->expects($this->at(3))
             ->method('log')
             ->with(Logger::DEBUG,
-                'Dispatching conversion event to URL logx.optimizely.com/track with params val1.');
+                'Dispatching conversion event to URL logx.optimizely.com/track with params param1=val1.');
 
         $optlyObject = new Optimizely($this->datafile, new ValidEventDispatcher(), $this->loggerMock);
 
@@ -656,7 +656,7 @@ public function testTrackNoAttributesWithEventValue()
         $this->loggerMock->expects($this->at(5))
             ->method('log')
             ->with(Logger::DEBUG,
-                'Dispatching conversion event to URL logx.optimizely.com/track with params val1.');
+                'Dispatching conversion event to URL logx.optimizely.com/track with params param1=val1.');
 
         $optlyObject = new Optimizely($this->datafile, new ValidEventDispatcher(), $this->loggerMock);
 
@@ -712,7 +712,7 @@ public function testTrackWithAttributesWithEventValue()
         $this->loggerMock->expects($this->at(5))
             ->method('log')
             ->with(Logger::DEBUG,
-                'Dispatching conversion event to URL logx.optimizely.com/track with params val1.');
+                'Dispatching conversion event to URL logx.optimizely.com/track with params param1=val1.');
 
         $optlyObject = new Optimizely($this->datafile, new ValidEventDispatcher(), $this->loggerMock);