[GR-13405] GitHub issue #49: dims attribute value is RDoubleVector, which causes ClassCastException when retrieving the dims.

PullRequest: fastr/1893

Author: steve-s

CHANGELOG.md

@@ -25,6 +25,7 @@ Bug fixes:
 * `env2list` error for environments containing pairlists
 * `body<-` error for non-scalar values
 * `unlink` error for paths containing wildcard(s) but no path separator
+*  dims attribute errorneously set to RDoubleVector; exception when retrieving the dims #49
 
 # 1.0 RC 11
 

com.oracle.truffle.r.nodes/src/com/oracle/truffle/r/nodes/attributes/SetAttributeNode.java

@@ -1,5 +1,5 @@
 /*
- * Copyright (c) 2016, 2018, Oracle and/or its affiliates. All rights reserved.
+ * Copyright (c) 2016, 2019, Oracle and/or its affiliates. All rights reserved.
  * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
  *
  * This code is free software; you can redistribute it and/or modify it
@@ -144,11 +144,13 @@ protected void setSpecAttrInAttributable(RAttributable x, String name, Object va
         genericSpecialAttrNode.execute(x, name, value);
     }
 
-    @Specialization
+    @Specialization(guards = "!isSpecialAttributeNode.execute(name)")
+    @SuppressWarnings("unused")
     protected void setAttrInAttributable(RAttributable x, String name, Object value,
                     @Cached("create()") BranchProfile attrNullProfile,
                     @Cached("createBinaryProfile()") ConditionProfile attrStorageProfile,
                     @Cached("createClassProfile()") ValueProfile xTypeProfile,
+                    @Cached("create()") SpecialAttributesFunctions.IsSpecialAttributeNode isSpecialAttributeNode,
                     @Cached("create()") ShareObjectNode updateRefCountNode) {
         DynamicObject attributes;
         if (attrStorageProfile.profile(x instanceof RAttributeStorage)) {

com.oracle.truffle.r.test.native/packages/testrffi/testrffi/R/testrffi.R

@@ -285,3 +285,7 @@ rffi.shareListElement <- function(x, xi, y, yi) {
 rffi.test_setVar <- function(symbol, value, env) {
     .Call('test_Rf_setVar', symbol, value, env)
 }
+
+rffi.test_setAttribDimDoubleVec <- function(vec, dimDoubleVec) {
+    .Call('test_Rf_setAttribDimDoubleVec', vec, dimDoubleVec)
+}

com.oracle.truffle.r.test.native/packages/testrffi/testrffi/src/testrffi.c

@@ -909,3 +909,12 @@ SEXP test_Rf_setVar(SEXP symbol, SEXP value, SEXP env) {
     Rf_setVar(symbol, value, env);
     return R_NilValue;
 }
+
+SEXP test_Rf_setAttribDimDoubleVec(SEXP vec, SEXP dimDoubleVec) {
+    Rf_setAttrib(vec, PROTECT(install("someNonSpecialAttrName")), PROTECT(allocVector(INTSXP, 42))); // Choose SetAttributeNode's non-special attr specialization
+    Rf_setAttrib(vec, PROTECT(install("dim")), dimDoubleVec); // and remain on it (no guard was on it)
+    UNPROTECT(3);
+    return R_NilValue;
+}
+
+

com.oracle.truffle.r.test.native/packages/testrffi/testrffi/tests/simpleTests.R

@@ -374,3 +374,8 @@ rffi.test_setVar(as.symbol('y'), 42, e)
 stopifnot(identical(e$y, NULL))
 stopifnot(identical(globalenv()$y, 42))
 
+v <- c(1:6)
+d <- c(2.0, 3.0)
+rffi.test_setAttribDimDoubleVec(v, d)
+print(dim(v))
+

com.oracle.truffle.r.test/src/com/oracle/truffle/r/test/ExpectedTestOutput.test

@@ -77583,6 +77583,12 @@ Error: unexpected '}' in "{ .Internal(strrep(, '') }"
 #{ strrep(c("A", "B", "C"), 1 : 3) }
 [1] "A"   "BB"  "CCC"
 
+##com.oracle.truffle.r.test.builtins.TestBuiltin_strsplit.testStrSplit#
+#strsplit('/some/path/to/somewhere' , '^(?=/)(?!//)|(?<!^)(?<!^/)/', perl = TRUE)
+[[1]]
+[1] "/"         "some"      "path"      "to"        "somewhere"
+
+
 ##com.oracle.truffle.r.test.builtins.TestBuiltin_strsplit.testStrSplit#
 #strsplit('1', '1', fixed=FALSE)
 [[1]]