remove obsolete java iterable handling in ForNode

Author: tomasstupka

com.oracle.truffle.r.nodes/src/com/oracle/truffle/r/nodes/control/ForNode.java

@@ -29,13 +29,11 @@
 import com.oracle.truffle.api.dsl.NodeChild;
 import com.oracle.truffle.api.dsl.Specialization;
 import com.oracle.truffle.api.frame.VirtualFrame;
-import com.oracle.truffle.api.interop.ArityException;
 import com.oracle.truffle.api.interop.ForeignAccess;
 import com.oracle.truffle.api.interop.Message;
 import com.oracle.truffle.api.interop.TruffleObject;
 import com.oracle.truffle.api.interop.UnknownIdentifierException;
 import com.oracle.truffle.api.interop.UnsupportedMessageException;
-import com.oracle.truffle.api.interop.UnsupportedTypeException;
 import com.oracle.truffle.api.nodes.LoopNode;
 import com.oracle.truffle.api.nodes.Node;
 import com.oracle.truffle.api.nodes.UnexpectedResultException;
@@ -172,10 +170,6 @@ protected WriteVariableNode createWriteVariable(String name) {
         return WriteVariableNode.createAnonymous(name, Mode.REGULAR, null);
     }
 
-    protected LoopNode createForIterableLoopNode(String iteratorName) {
-        return createLoopNode(new ForIterableRepeatingNode(this, var.getIdentifier(), RASTUtils.cloneNode(body), iteratorName));
-    }
-
     protected LoopNode createForKeysLoopNode(String indexName, String positionName, String lengthName, String rangeName, String keysName) {
         return createLoopNode(new ForKeysRepeatingNode(this, var.getIdentifier(), RASTUtils.cloneNode(body), indexName, positionName, lengthName, rangeName, keysName));
     }
@@ -320,81 +314,6 @@ protected void writePosition(VirtualFrame frame, int index) {
         }
     }
 
-    private static final class ForIterableRepeatingNode extends AbstractRepeatingNode {
-
-        private final ConditionProfile conditionProfile = ConditionProfile.createBinaryProfile();
-        private final BranchProfile breakBlock = BranchProfile.create();
-        private final BranchProfile nextBlock = BranchProfile.create();
-
-        @Child private WriteVariableNode writeElementNode;
-        @Child private LocalReadVariableNode readIteratorNode;
-
-        @Child private Node readForeignNode;
-        @Child private Node executeForeignNode;
-
-        // only used for toString
-        private final ForNode forNode;
-
-        ForIterableRepeatingNode(ForNode forNode, String var, RNode body, String iteratorName) {
-            super(body);
-            this.forNode = forNode;
-            this.writeElementNode = WriteVariableNode.createAnonymous(var, Mode.REGULAR, createNextLoad(iteratorName), false);
-
-            this.readIteratorNode = LocalReadVariableNode.create(iteratorName, true);
-
-            this.executeForeignNode = Message.EXECUTE.createNode();
-            this.readForeignNode = Message.READ.createNode();
-
-            // pre-initialize the profile so that loop exits to not deoptimize
-            conditionProfile.profile(false);
-        }
-
-        private static RNode createNextLoad(String iteratorName) {
-            RCodeBuilder<RSyntaxNode> builder = RContext.getASTBuilder();
-            RSyntaxNode receiver = builder.lookup(RSyntaxNode.INTERNAL, iteratorName, false);
-            RSyntaxNode next = builder.lookup(RSyntaxNode.INTERNAL, "next", true);
-            RSyntaxNode access = builder.lookup(RSyntaxNode.INTERNAL, "$", true);
-            RSyntaxNode nextCall = builder.call(RSyntaxNode.INTERNAL, access, receiver, next);
-            return builder.call(RSyntaxNode.INTERNAL, nextCall).asRNode();
-        }
-
-        @Override
-        public boolean executeRepeating(VirtualFrame frame) {
-            try {
-                TruffleObject iterator = (TruffleObject) readIteratorNode.execute(frame);
-                assert iterator != null;
-
-                if (conditionProfile.profile(hasNext(iterator))) {
-                    writeElementNode.voidExecute(frame);
-                    body.voidExecute(frame);
-                    return true;
-                }
-                return false;
-            } catch (BreakException e) {
-                breakBlock.enter();
-                return false;
-            } catch (NextException e) {
-                nextBlock.enter();
-                return true;
-            }
-        }
-
-        private boolean hasNext(TruffleObject iterator) {
-            try {
-                TruffleObject hasNextFun = (TruffleObject) ForeignAccess.sendRead(readForeignNode, iterator, "hasNext");
-                return (boolean) ForeignAccess.sendExecute(executeForeignNode, hasNextFun);
-            } catch (UnknownIdentifierException | UnsupportedMessageException | UnsupportedTypeException | ArityException ex) {
-                throw RInternalError.shouldNotReachHere(ex, "Could not retrieve hasNext function");
-            }
-        }
-
-        @Override
-        public String toString() {
-            return forNode.toString();
-        }
-
-    }
-
     @Override
     public RSyntaxElement[] getSyntaxArguments() {
         return new RSyntaxElement[]{var, getRange().asRSyntaxNode(), body.asRSyntaxNode()};