Convert RList to use the storage strategy pattern

Author: steve-s

com.oracle.truffle.r.library/src/com/oracle/truffle/r/library/fastrGrid/ViewPort.java

@@ -164,10 +164,9 @@ public RList execute(VirtualFrame frame) {
 
             GridDevice device = GridContext.getContext().getCurrentDevice();
             // TODO: properly set the scale according to the current device
-            Object[] data = topVP.getDataWithoutCopying();
-            data[ViewPort.VP_XSCALE] = RDataFactory.createDoubleVector(new double[]{0, device.getNativeWidth()}, RDataFactory.COMPLETE_VECTOR);
-            data[ViewPort.VP_YSCALE] = RDataFactory.createDoubleVector(new double[]{device.getNativeHeight(), 0}, RDataFactory.COMPLETE_VECTOR);
-            data[ViewPort.PVP_GPAR] = GridContext.getContext().getGridState().getGpar();
+            topVP.setDataAt(ViewPort.VP_XSCALE, RDataFactory.createDoubleVector(new double[]{0, device.getNativeWidth()}, RDataFactory.COMPLETE_VECTOR));
+            topVP.setDataAt(ViewPort.VP_YSCALE, RDataFactory.createDoubleVector(new double[]{device.getNativeHeight(), 0}, RDataFactory.COMPLETE_VECTOR));
+            topVP.setDataAt(ViewPort.PVP_GPAR, GridContext.getContext().getGridState().getGpar());
             return DoSetViewPort.doSetViewPort(topVP, false, true);
         }
     }

com.oracle.truffle.r.nodes.builtin/src/com/oracle/truffle/r/nodes/builtin/base/Combine.java

@@ -241,7 +241,7 @@ private static Object combineRecursive(RArgsValuesAndNames args, Combine recursi
         for (int i = 0; i < argsArray.length; i++) {
             Object arg = argsArray[i];
             if (arg instanceof RList) {
-                Object[] argsFromList = ((RList) arg).getDataWithoutCopying();
+                Object[] argsFromList = ((RList) arg).getReadonlyData();
                 newArgsArray[i] = recursiveCombine.executeCombine(new RArgsValuesAndNames(argsFromList,
                                 ArgumentsSignature.empty(argsFromList.length)), true);
                 useNewArgs = true;

com.oracle.truffle.r.runtime/src/com/oracle/truffle/r/runtime/RErrorHandling.java

@@ -1,7 +1,7 @@
 /*
  * Copyright (c) 1995-2015, The R Core Team
  * Copyright (c) 2003, The R Foundation
- * Copyright (c) 2015, 2019, Oracle and/or its affiliates
+ * Copyright (c) 2015, 2020, Oracle and/or its affiliates
  *
  * This program is free software; you can redistribute it and/or modify
  * it under the terms of the GNU General Public License as published by
@@ -425,10 +425,9 @@ static void signalError(RBaseNode callObj, Message msg, Object... args) {
     private static ReturnException gotoExitingHandler(Object cond, Object call, RList entry) throws ReturnException {
         REnvironment rho = (REnvironment) entry.getDataAt(ENTRY_TARGET_ENVIR);
         RList result = (RList) entry.getDataAt(ENTRY_RETURN_RESULT);
-        Object[] resultData = result.getDataWithoutCopying();
-        resultData[RESULT_COND] = cond;
-        resultData[RESULT_CALL] = call;
-        resultData[RESULT_HANDLER] = entry.getDataAt(ENTRY_HANDLER);
+        result.setDataAt(RESULT_COND, cond);
+        result.setDataAt(RESULT_CALL, call);
+        result.setDataAt(RESULT_HANDLER, entry.getDataAt(ENTRY_HANDLER));
         throw new ReturnException(result, RArguments.getCall(rho.getFrame()));
     }
 

com.oracle.truffle.r.runtime/src/com/oracle/truffle/r/runtime/data/RDoubleForeignObjData.java

@@ -1,5 +1,5 @@
 /*
- * Copyright (c) 2019, 2020, Oracle and/or its affiliates. All rights reserved.
+ * Copyright (c) 2020, 2020, Oracle and/or its affiliates. All rights reserved.
  * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER.
  *
  * This code is free software; you can redistribute it and/or modify it