Skip to content

Commit be2fa03

Browse files
committed
squash: consolidate VM args that should be in sync
1 parent 59dfaf1 commit be2fa03

File tree

2 files changed

+12
-4
lines changed

2 files changed

+12
-4
lines changed

sdk/mx.sdk/mx_sdk.py

Lines changed: 11 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -261,6 +261,16 @@ def jlink_new_jdk(jdk, dst_jdk_dir, module_dists, ignore_dists,
261261
default_to_jvmci=default_to_jvmci)
262262

263263
class GraalVMJDKConfig(mx.JDKConfig):
264+
265+
# Oracle JDK includes the libjvmci compiler, allowing it to function as GraalVM.
266+
# However, the Graal compiler is disabled by default and must be explicitly
267+
# enabled using the -XX:+UseGraalJIT option.
268+
libgraal_additional_vm_args = [
269+
'-XX:+UnlockExperimentalVMOptions',
270+
'-XX:+EnableJVMCI',
271+
'-XX:+UseGraalJIT',
272+
'-XX:-UnlockExperimentalVMOptions'
273+
]
264274
"""
265275
A JDKConfig that configures the built GraalVM as a JDK config.
266276
"""
@@ -270,10 +280,8 @@ def __init__(self):
270280
graalvm_home = default_jdk.home
271281
additional_vm_args = []
272282
elif GraalVMJDKConfig.is_libgraal_jdk(default_jdk.home):
273-
# Oracle JDK includes the libjvmci compiler, allowing it to function as GraalVM.
274-
# However, the Graal compiler is disabled by default and must be explicitly enabled using the -XX:+UseGraalJIT option.
275283
graalvm_home = default_jdk.home
276-
additional_vm_args = ['-XX:+UnlockExperimentalVMOptions', '-XX:+EnableJVMCI', '-XX:+UseGraalJIT', '-XX:-UnlockExperimentalVMOptions']
284+
additional_vm_args = GraalVMJDKConfig.libgraal_additional_vm_args
277285
else:
278286
graalvm_home = mx_sdk_vm.graalvm_home(fatalIfMissing=True)
279287
additional_vm_args = []

truffle/mx.truffle/mx_truffle.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -499,7 +499,7 @@ def _truffle_gate_runner(args, tasks):
499499

500500
def gate_truffle_jvm(tasks):
501501
if mx_sdk.GraalVMJDKConfig.is_libgraal_jdk(mx.get_jdk(tag='default').home):
502-
additional_jvm_args = ['-XX:+UnlockExperimentalVMOptions', '-XX:+EnableJVMCI', '-XX:-UnlockExperimentalVMOptions']
502+
additional_jvm_args = mx_sdk.GraalVMJDKConfig.libgraal_additional_vm_args
503503
else:
504504
additional_jvm_args = []
505505
# GR-62632: Debug VM exception translation failure

0 commit comments

Comments
 (0)