Skip to content

Commit 6ed4fe7

Browse files
committed
avoid NPE
1 parent 36830bf commit 6ed4fe7

File tree

2 files changed

+7
-6
lines changed

2 files changed

+7
-6
lines changed

operator/src/main/java/oracle/kubernetes/weblogic/domain/model/DomainStatus.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -322,8 +322,8 @@ private ServerStatus adjust(ServerStatus server) {
322322
private ServerStatus getMatchingServer(ServerStatus server) {
323323
return getServers()
324324
.stream()
325-
.filter(s -> s.getClusterName().equals(server.getClusterName()))
326-
.filter(s -> s.getServerName().equals(server.getServerName()))
325+
.filter(s -> Objects.equals(s.getClusterName(), server.getClusterName()))
326+
.filter(s -> Objects.equals(s.getServerName(), server.getServerName()))
327327
.findFirst()
328328
.orElse(null);
329329
}

operator/src/test/java/oracle/kubernetes/weblogic/domain/model/DomainStatusTest.java

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,7 @@
66
import java.util.ArrayList;
77
import java.util.Arrays;
88
import java.util.List;
9+
import java.util.Objects;
910

1011
import com.meterware.simplestub.Memento;
1112
import oracle.kubernetes.utils.SystemClockTestSupport;
@@ -292,12 +293,12 @@ public void whenMatchingServersExist_setServersUpdatesState() {
292293
domainStatus.setServers(Arrays.asList(
293294
new ServerStatus().withClusterName("1").withServerName("1").withState("state1"),
294295
new ServerStatus().withClusterName("1").withServerName("2").withState("state1"),
295-
new ServerStatus().withClusterName("1").withServerName("3").withState("state2")
296+
new ServerStatus().withServerName("admin").withIsAdminServer(true).withState("state2")
296297
));
297298

298299
assertThat(getServer("1", "1").getState(), equalTo("state1"));
299300
assertThat(getServer("1", "2").getState(), equalTo("state1"));
300-
assertThat(getServer("1", "3").getState(), equalTo("state2"));
301+
assertThat(getServer(null, "admin").getState(), equalTo("state2"));
301302
}
302303

303304
@Test
@@ -334,8 +335,8 @@ public void whenSetServerIncludesServerWithoutStateAndHasExistingState_preserveI
334335
private ServerStatus getServer(String clusterName, String serverName) {
335336
return domainStatus.getServers()
336337
.stream()
337-
.filter(s -> s.getClusterName().equals(clusterName))
338-
.filter(s -> s.getServerName().equals(serverName))
338+
.filter(s -> Objects.equals(clusterName, s.getClusterName()))
339+
.filter(s -> Objects.equals(serverName, s.getServerName()))
339340
.findFirst()
340341
.orElse(null);
341342
}

0 commit comments

Comments
 (0)