Themes 15.0.1 - provide uncompressed css / why literal instead unicode icon?

[djmj]

Migrating from version 5.0.0 to 15.0.1 i have following problem:

Uncompressed

There is no uncompressed css anymore. Which is easier to compare since in certain themes i have a lot of modifications inline.
Since i was converting it to css variables.

Icon content as literal

Suddenly the content is saved as literal instead of unicode, making it even harder to compare and identify / change icons. Sometimes i am rewriting icons to use font-awesome instead.

Use { content: "\e902" } instead of { content: "" } which makes it more flexible and easier to use.

With file encoding i have to check not loosing it and getting content: "?"

[tandraschko]

Uncompressed:
both contain the SCSS files, not sure if there is a compiled leftover. Which file do you mean? Anyway, just use the scss.

Icon content as literal
we didnt change it in the last releases, so propably just history.

[djmj]

In 5.0.0 file primefaces-freya-blue-light/theme.css was uncompressed as release. Not that important though.

5.0.0

But in 5.0.0 icons were defined using unicode like { content: "\e902" }.

body .ui-wizard .ui-icon-arrowthick-1-e:before {
  content: "\e91b";
}

15.0.1

body .ui-wizard .ui-icon-arrowthick-1-e:before {
  content:""
}

Yes it has changed and leads to problems when trying to copy it in eclipse.

I copy { content: "" } and eclipse display { content: "?" } even if file is encoded as utf-8 in eclipse.
Not every editor like eclipse/ notepad displays it correctly. They just display a "[?]".

Its encoding independent if you use the unicode { content: "\e902" } as before.

Maybe this happened during packaging of the release?

[tandraschko]

why you care about the css - you should not touch it, just the scss.
and this is readable correct:
@include icon-override('\e91b');

[djmj]

Icon replacement

Sometimes i replace primeicons with font-awesome icons in theme.css so i need search and read "\e902". Makes it much harder when i only see [?] in editor.

Why do i replace them? Cause primeicons is not sufficient to cover enough icons and i want consistency in my application / code using only one icon provider (font-awesome).

What is @include icon-override('\e91b');?

Once primefaces components use primeicon css classes directly instead of legacy ui-icon this becomes obsolete anyway. Then i can replace the icons directly adding pi rules to my font-awesome css files.

File encoding independence

Using content: "\e902" you stay in ASCII characters, so file does not need UTF-8 and could be converted to ASCII.

[tandraschko]

propably because of history - we have that pattern since ages in PrimeFaces core theming, as we supported jQueryUI Icons, PrimeIcons and FontAwesome.
For the templates, we just switchted to a mechnamism, that the theme core is reused/copied from PrimeFaces.

we propably wont change here anything. the next big task is to move to PrimeUIX completely instead of rewriting parts of the old sass theming.

[djmj]

Yes understandable.

But what was? @include icon-override('\e91b');

Can i override icons with something like this without changing the original theme.css file?

[tandraschko]

check the scss of the template, its in there

[djmj]

Ah thank you!