UNKNOWN_COMPILER_VERSION

[zuobaoquan]

Hi, I addressed a tricky bug which was caused by an outdated jedi.inc. I looked into the file and found this part:

{$IFDEF UNKNOWN_COMPILER_VERSION} // adjust for newer version (always use latest version)
  {$DEFINE BDS}
  {$DEFINE BDS23}
  {$DEFINE COMPILER29}
  {$IFDEF BCB}
    {$DEFINE BCB29}
  {$ELSE}
    {$DEFINE DELPHI29}
    {$DEFINE DELPHICOMPILER29}
  {$ENDIF BCB}
  {$DEFINE RTL360_UP}
  {$UNDEF UNKNOWN_COMPILER_VERSION}
{$ENDIF}

It always fallbacks to "latest" version, but it might introduce subtle bugs. e.g. the following example code still compiles in Delphi 13:

const CoreIdeName = 
{$IFDEF DELPHI29}
   'coreide290.bpl';
{$ELSE}
   {$MESSAGE ERROR 'UNKNOWN Compiler Version'}
{$ENDIF}

It becomes a runtime bug instead of a compilation error.

how about other approaches? e.g.

• Just report compiler error 'Unknown compiler version'
  or
• Define DELPHI29_UP like symbols but not DELPHI29

[UweRaabe]

IMHO, it should not fallback to the latest version, but to the expected next version. Most of the time the relevant defines can be guessed. That way there is enough time to extend the file when a new IDE version is released.

As the most relevant defines are the _UP ones, that should cover the majority of use cases.

[ronaldhoek]

I would prefer only defining the _up defines and not the specific defines.
This way most of the code will compile when the new version arrives. And version specific code will give an error like CoreIdeName.

[obones]

Yes, I'm more on that line as well.
I'll leave the discussion as is for the next few days to see what comes out of it, but I'm leaning towards replacing the block starting at line 1190 by this:

    {$IFDEF UNKNOWN_COMPILER_VERSION} // adjust for newer version (always use latest version)
      {$DEFINE BDS}
      {$DEFINE BDS37_UP}
      {$DEFINE COMPILER37_UP}
      {$IFDEF BCB}
        {$DEFINE BCB37_UP}
      {$ELSE}
        {$DEFINE DELPHI37_UP}
        {$DEFINE DELPHICOMPILER37_UP}
      {$ENDIF BCB}
      {$DEFINE RTL370_UP}
      {$UNDEF UNKNOWN_COMPILER_VERSION}
    {$ENDIF}

Basically, add the _UP suffix to all defined symbol

[ronaldhoek]

For more clarity, it would also be best to remove the {$UNDEF UNKNOWN_COMPILER_VERSION} so the define UNKNOWN_COMPILER_VERSION still exists (because that's officially the case).
But I'm not sure what the consequences are for keeping the UNKNOWN_COMPILER_VERSION define.

[obones]

I could not see anything negative in the JCL nor the JVCL as it appears UNKNOWN_COMPILER_VERSION is not used in source files

[ronaldhoek]

Regarding the comments // adjust for newer version (always use latest version) I would also change it to:

// adjust for newer version (always use latest XXX_UP versions only)