urlLogical not causing path update in browser?

[jakeaturner]

Hello,

Thank you for building Vike. I am trying to get i18n working following the docs, particularly the piece about removing the locale from the path. I can successfully set and render the correct locale, but the logical url is not being set as expected. I thought I had this working for a moment, but I guess I changed something and goofed it up.

I have created a minimal reproduction here

If you start the app and visit /star-wars, it should load without issue. If you go to /es-mx/star-wars, you will see that the page still loads fine, but the actual path in the browser is not updated. I added logging to my +onBeforeRoute function and you can see this output:

urlPathnameWithoutLocale /star-wars
locale es-mx
urlLogical /star-wars

I am sure there is some obvious mistake I am making here, but I'm a bit lost so I appreciate any help.

P.S. I realize in my reproduction that the spanish version of the text only flashes for a moment, but I am not so worried about this as I have vue-i18n functioning just fine in my real app.

[brillout]

but the actual path in the browser is not updated

Modifying pageContext doesn't have side-effects and doesn't change the URL. You do this part yourself, for example if go to /es-mx/star-wars manually then you'll see it works.

Let me improve the docs to be clearer.

[brillout]

Let me improve the docs to be clearer.

Done:

• 9674f66
• https://vike.dev/i18n

Let me know if the docs are still unclear.

[jakeaturner]

Thanks!