Skip to content

Commit 53cf2dd

Browse files
committed
feat(prometheus): add 1h window just for fun
- we would like to compare it with current slo-generator Signed-off-by: Hy3n4 <[email protected]>
1 parent 24f1b42 commit 53cf2dd

File tree

2 files changed

+15
-3
lines changed

2 files changed

+15
-3
lines changed

helm/osko/Chart.yaml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,13 +15,13 @@ type: application
1515
# This is the chart version. This version number should be incremented each time you make changes
1616
# to the chart and its templates, including the app version.
1717
# Versions are expected to follow Semantic Versioning (https://semver.org/)
18-
version: 0.0.9
18+
version: 0.0.10
1919

2020
# This is the version number of the application being deployed. This version number should be
2121
# incremented each time you make changes to the application. Versions are not expected to
2222
# follow Semantic Versioning. They should reflect the version the application is using.
2323
# It is recommended to use it with quotes.
24-
appVersion: "0.0.9"
24+
appVersion: "0.0.10"
2525

2626
home: https://github.com/oskoperator/osko
2727

internal/helpers/prometheus_helper.go

Lines changed: 13 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -254,34 +254,46 @@ func (mrs *MonitoringRuleSet) SetupRules() ([]monitoringv1.Rule, error) {
254254

255255
totalRuleExtended := mrs.createRecordingRule(totalRuleBase.Record, "sli_total", extendedWindow, true)
256256
goodRuleExtended := mrs.createRecordingRule(goodRuleBase.Record, "sli_good", extendedWindow, true)
257+
totalRuleExtendedPageFast := mrs.createRecordingRule(totalRuleBase.Record, "sli_total", "1h", true)
258+
goodRuleExtendedPageFast := mrs.createRecordingRule(totalRuleBase.Record, "sli_good", "1h", true)
257259

258260
sliMeasurementBase := mrs.createSliMeasurementRecordingRule(totalRuleBase, goodRuleBase, baseWindow)
259261
sliMeasurementExtended := mrs.createSliMeasurementRecordingRule(totalRuleExtended, goodRuleExtended, extendedWindow)
262+
sliMeasurementExtendedPageFast := mrs.createSliMeasurementRecordingRule(totalRuleExtendedPageFast, goodRuleExtendedPageFast, "1h")
260263

261264
errorBudgetAvailableBase := mrs.createErrorBudgetValueRecordingRule(sliMeasurementBase, baseWindow)
262265
errorBudgetAvailableExtended := mrs.createErrorBudgetValueRecordingRule(sliMeasurementExtended, extendedWindow)
266+
errorBudgetAvailableExtendedPageFast := mrs.createErrorBudgetValueRecordingRule(sliMeasurementExtendedPageFast, "1h")
263267

264268
errorBudgetTargetBase := mrs.createErrorBudgetTargetRecordingRule(baseWindow)
265269
errorBudgetTargetExtended := mrs.createErrorBudgetTargetRecordingRule(extendedWindow)
270+
errorBudgetTargetExtendedPageFast := mrs.createErrorBudgetTargetRecordingRule("1h")
266271

267272
burnRateBase := mrs.createBurnRateRecordingRule(errorBudgetAvailableBase, errorBudgetTargetBase, baseWindow)
268273
burnRateExtended := mrs.createBurnRateRecordingRule(errorBudgetAvailableExtended, errorBudgetTargetExtended, extendedWindow)
274+
burnRateExtendedPageFast := mrs.createBurnRateRecordingRule(errorBudgetAvailableExtendedPageFast, errorBudgetTargetExtendedPageFast, "1h")
269275

270276
rules := []monitoringv1.Rule{
271277
targetRuleBase,
272-
targetRuleExtended,
273278
totalRuleBase,
279+
targetRuleExtended,
280+
totalRuleExtendedPageFast,
274281
goodRuleBase,
275282
totalRuleExtended,
276283
goodRuleExtended,
284+
totalRuleExtendedPageFast,
277285
sliMeasurementBase,
278286
sliMeasurementExtended,
287+
sliMeasurementExtendedPageFast,
279288
errorBudgetAvailableBase,
280289
errorBudgetAvailableExtended,
290+
errorBudgetAvailableExtendedPageFast,
281291
errorBudgetTargetBase,
282292
errorBudgetTargetExtended,
293+
errorBudgetTargetExtendedPageFast,
283294
burnRateBase,
284295
burnRateExtended,
296+
burnRateExtendedPageFast,
285297
}
286298

287299
return rules, nil

0 commit comments

Comments
 (0)