Merge pull request #2235 from joto/nodiscard-msg

joto · web-flow · commit 0de33f56625d · 2024-08-19T11:34:45.000+02:00
We are not planning to litter the code with [[nodiscard]]
diff --git a/.clang-tidy b/.clang-tidy
@@ -69,8 +69,9 @@ Checks: '*,-abseil-*,-altera-*,-android-cloexec-*,-bugprone-easily-swappable-par
 #    Lots of these, need some time to fix. (TODO)
 #
 #  modernize-use-nodiscard
-#    We have a lot of these. Remove it for the time being because there are
-#    too many to fix quickly. (TODO)
+#    Doesn't really make the code clearer if it is all littered with
+#    [[nodiscard]]. Looks like this warning is more suited for a library
+#    than for normal code.
 #
 #  modernize-use-trailing-return-type
 #    We are not that modern...

Original file line number	Diff line number	Diff line change
`@@ -69,8 +69,9 @@ Checks: ',-abseil-,-altera-,-android-cloexec-,-bugprone-easily-swappable-par`
`69`	`69`	`# Lots of these, need some time to fix. (TODO)`
`70`	`70`	`#`
`71`	`71`	`# modernize-use-nodiscard`
`72`		`-# We have a lot of these. Remove it for the time being because there are`
`73`		`-# too many to fix quickly. (TODO)`
	`72`	`+# Doesn't really make the code clearer if it is all littered with`
	`73`	`+# [[nodiscard]]. Looks like this warning is more suited for a library`
	`74`	`+# than for normal code.`
`74`	`75`	`#`
`75`	`76`	`# modernize-use-trailing-return-type`
`76`	`77`	`# We are not that modern...`