Remove potentially expensive copy operator from idlist_t

And fix the unnecessary copy this found.
osm2pgsql-dev · Mar 31, 2024 · 60987b4 · 60987b4
1 parent 3c1257e
commit 60987b4
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 1 deletion.
diff --git a/src/idlist.hpp b/src/idlist.hpp
@@ -27,9 +27,16 @@ class idlist_t
     using value_type = osmid_t;
 
     idlist_t() = default;
+    ~idlist_t() noexcept = default;
 
     idlist_t(std::initializer_list<osmid_t> ids) : m_list(ids) {}
 
+    idlist_t(idlist_t const &) = delete;
+    idlist_t &operator=(idlist_t const &) = delete;
+
+    idlist_t(idlist_t &&) = default;
+    idlist_t &operator=(idlist_t &&) = default;
+
     bool empty() const noexcept { return m_list.empty(); }
 
     std::size_t size() const noexcept { return m_list.size(); }

diff --git a/src/osmdata.cpp b/src/osmdata.cpp
@@ -364,7 +364,7 @@ void osmdata_t::process_dependents() const
     }
 
     // stage 1c processing: mark parent relations of marked objects as changed
-    auto marked_ways = m_output->get_marked_way_ids();
+    auto const &marked_ways = m_output->get_marked_way_ids();
     if (marked_ways.empty()) {
         return;
     }