Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecating gazetteer output #1311

Closed
3 of 4 tasks
lonvia opened this issue Nov 6, 2020 · 4 comments
Closed
3 of 4 tasks

Deprecating gazetteer output #1311

lonvia opened this issue Nov 6, 2020 · 4 comments

Comments

@lonvia
Copy link
Collaborator

lonvia commented Nov 6, 2020

With the flex output, there is no need to have a separate gazetteer output, as it allows to configure most of what we need. This tickets collects the features that would still be needed on the osm2pgsql side to get the flex output on par with the current gazetteer implementation:

  • Geometry caching. Gazetteer occasionally calls add_row() twice for the same object.
  • Do not create an index on the geometry column.
  • Do not cluster table.
  • Disable handling of forward dependencies on a per-table base.

The tasks for the Nominatim side are collected at osm-search/Nominatim#2047.

@joto
Copy link
Collaborator

joto commented Nov 25, 2020

Having Nominatim use the flex output, would open up the possibility of generating a single database for rendering and geocoding. Something that a lot of people want.

At a minimum this would need some mechanism for handling the difference in processing though: For the rendering db osm2pgsql needs to handle the forward dependencies in append mode, Nominatim doesn't need that.

@joto
Copy link
Collaborator

joto commented Dec 7, 2022

With the merge of #1847 another big step towards this has been taken. See also https://nominatim.org/2022/11/28/towards-flex.html .

@lonvia
Copy link
Collaborator Author

lonvia commented Dec 23, 2022

Handling of forward dependencies has been rendered moot by osm-search/Nominatim#2927.
osm-search/Nominatim#2932 fully switches Nominatim to flex.

The one task that remains is to remove the gazetteer output. I don't think we need much of a deprecation period as the output was only ever meant to be used with Nominatim.

@joto
Copy link
Collaborator

joto commented Jan 5, 2023

Closing in favour of #1870.

@joto joto closed this as completed Jan 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants