Skip to content
This repository has been archived by the owner on Mar 22, 2021. It is now read-only.

Refactor Network Classes (Interface and Fault Injection) #44

Closed
wants to merge 18 commits into from

Conversation

arneboockmeyer
Copy link
Collaborator

@arneboockmeyer arneboockmeyer commented Aug 19, 2020

@arneboockmeyer arneboockmeyer self-assigned this Aug 19, 2020
@arneboockmeyer arneboockmeyer changed the title WIP: Refactor network logic for better IP-Addresses handling Refactor Network Classes (Interface and Fault Injection) Oct 19, 2020
@arneboockmeyer arneboockmeyer requested a review from rs22 October 19, 2020 13:50
@arneboockmeyer
Copy link
Collaborator Author

@rs22 could you please review this? 😃

@rs22
Copy link
Member

rs22 commented Nov 27, 2020

Sorry for the (long!) delay. Will review this later today.

Copy link
Member

@rs22 rs22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left a few remarks. As always, these are just personal opinion and you may well disregard them if you like -- I'm not the authority here. 😄

@rs22 rs22 assigned arneboockmeyer and unassigned rs22 Feb 22, 2021
@arneboockmeyer
Copy link
Collaborator Author

@rs22 I applied all your comments. Thanks for your feedback. Please review again 😃

@arneboockmeyer arneboockmeyer requested a review from rs22 March 19, 2021 11:02
@arneboockmeyer
Copy link
Collaborator Author

Replaced by diselab#7

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add option to change delay of networks after simulation start
2 participants