Problem
When choosing a snippet with ORIGINAL_FINDING, then all snippet findings which match
purl and sourceLocation will be set to "identified", no matter if startLine or endline is matching.
So, startLine and endLine is not considered at all [1], which is counter intuitive / misleading for users.
Upstream disussion
scanoss/scanoss.java#41
Goal
Figure out if we can enhance the implementation, so that matching on snippet granularity is possible.
[1]
|
private fun MutableList<Rule>.includeFinding(choice: SnippetChoice) { |
|
this += Rule.builder() |
|
.purl(choice.choice.purl) |
|
.path(choice.given.sourceLocation.path) |
|
.build() |
|
} |
Problem
When choosing a snippet with
ORIGINAL_FINDING, then all snippet findings which matchpurlandsourceLocationwill be set to "identified", no matter ifstartLineorendlineis matching.So,
startLineandendLineis not considered at all [1], which is counter intuitive / misleading for users.Upstream disussion
scanoss/scanoss.java#41
Goal
Figure out if we can enhance the implementation, so that matching on snippet granularity is possible.
[1]
ort/plugins/scanners/scanoss/src/main/kotlin/ScanOss.kt
Lines 185 to 190 in ce9007f