Skip to content

Commit 4da9a86

Browse files
adaluongAda Luongoliverchang
authored
Modify completed analysis topic environment variable and add documentation for running locally (#531)
* fix merge conflict * Publish notification after analysis for a new package is completed * Modify worker to use package representation from resultstore for completed analysis notifications * Fix style to address review comments * Make notificationTopic consistent with other variables * Make error messages more concise * Modify publishNotification parameters to take in raw input * Remove unecessary variables * Fix topic name for consistency Signed-off-by: Ada Luong <[email protected]> * Create notification package Signed-off-by: Ada Luong <[email protected]> * Make completed analysis notifications optional Signed-off-by: Ada Luong <[email protected]> * Fix naming for notification message variables Signed-off-by: Ada Luong <[email protected]> * Simplify notification sending logic by moving it into messageLoop Signed-off-by: Ada Luong <[email protected]> * clarified comment about the notificationTopic default value Signed-off-by: Ada Luong <[email protected]> * Add command to observe notifications topic Signed-off-by: Ada Luong <[email protected]> * Update config file to set environment variable for complete analysis notification Signed-off-by: Ada Luong <[email protected]> Signed-off-by: Ada Luong <[email protected]> Co-authored-by: Ada Luong <[email protected]> Co-authored-by: Oliver Chang <[email protected]>
1 parent 1161232 commit 4da9a86

File tree

2 files changed

+2
-1
lines changed

2 files changed

+2
-1
lines changed

examples/e2e/README.md

+1
Original file line numberDiff line numberDiff line change
@@ -39,6 +39,7 @@ Output from the Kafka PubSub topics can be inspected using
3939
2. Run `kafkacat` to observe the topics:
4040
- package-feeds: `kafkacat -C -J -b localhost:9094 -t package-feeds`
4141
- workers: `kafkacat -C -J -b localhost:9094 -t workers`
42+
- notifications: `kafkacat -C -J -b localhost:9094 -t notifications`
4243

4344
## Additional Notes
4445

infra/worker/workers-set.yaml

+1-1
Original file line numberDiff line numberDiff line change
@@ -32,7 +32,7 @@ spec:
3232
- name: OSSF_MALWARE_ANALYSIS_PACKAGES
3333
value: gs://ossf-malware-analysis-packages
3434
- name: OSSF_MALWARE_NOTIFICATION_TOPIC
35-
value: gcppubsub://projects/gosst-package-detection/subscriptions/analysis-notify
35+
value: gcppubsub://projects/ossf-malware-analysis/topics/analysis-notify
3636
securityContext:
3737
privileged: true
3838
volumeMounts:

0 commit comments

Comments
 (0)