Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

param management inconsistent #21

Open
LeonieFreisinger opened this issue Dec 8, 2022 · 0 comments
Open

param management inconsistent #21

LeonieFreisinger opened this issue Dec 8, 2022 · 0 comments
Labels
refactoring Refactoring of an existing functionality.

Comments

@LeonieFreisinger
Copy link
Collaborator

Status Quo
A benchmark instance or experiment instance receives various parameters as input. Currently, the input is given by defining parameters in a dataset_list and in a model_classes_and_params list.
Example:

    dataset_list = [
        Dataset(df=peyton_manning_df, name="peyton_manning", freq="D"),
    ]
    model_classes_and_params = [
        (SeasonalNaiveModel, {"n_forecasts": 4, 'K':5}),
    ]

Subsequently, they are assigned to the attributes of different classes and/ or separated into further categories. Currently, this happens partly in the __post_init__() of the Experiment(ABC) class and the __post_init__() of the Model(ABC). So far, we separate the params into _data_params and model_params.

Problem

  1. It would be great, to have one dedicated part to post-process, split and assign the input params. In my eyes, this should be on the experiment level.
  2. It's great to distinguish between _data_params and model_params. Further, I think we should introduce pred_params, which saves all prediction task-related information.
@LeonieFreisinger LeonieFreisinger added the refactoring Refactoring of an existing functionality. label Dec 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactoring Refactoring of an existing functionality.
Projects
None yet
Development

No branches or pull requests

1 participant