prevent users from having access to alien home dirs#1855
Open
varuzam wants to merge 1 commit intooutroll:masterfrom
Open
prevent users from having access to alien home dirs#1855varuzam wants to merge 1 commit intooutroll:masterfrom
varuzam wants to merge 1 commit intooutroll:masterfrom
Conversation
luizjr
approved these changes
Apr 9, 2019
varuzam
changed the title
|
The idea is not bad in itself, but that's like building a 2 foot high fence to protect your treasure, as it would not stop the web process from having access to those alien directories. I don't see a reason against it, but simply wanted to point out that it may give a false sense of security. |
Author
|
It protects if webapp is running as fastcgi. In this case apache doesnt
execute any user's code
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
it fixes this issue #969
the eventual result
The users test1 and test2 dont have access to dir of each