Skip to content

Commit 393e8ff

Browse files
authored
Merge pull request #760 from AdamTovatt/patch-1
Update UPGRADE-0.11.md
2 parents 75c661c + 851d81f commit 393e8ff

File tree

1 file changed

+16
-16
lines changed

1 file changed

+16
-16
lines changed

UPGRADE-0.11.md

+16-16
Original file line numberDiff line numberDiff line change
@@ -134,12 +134,12 @@ UPGRADE FROM 0.10 to 0.11
134134
```
135135
### Type autoMapping and Symfony DI `autoconfigure`
136136

137-
When using these functionality, type will be accessible only by FQCN in schema definition,
138-
(if class not implementing `Overblog\GraphQLBundle\Definition\Resolver\AliasedInterface`).
137+
When using these functionalities, type will be accessible only by FQCN in schema definition
138+
(if class doesn't implement `Overblog\GraphQLBundle\Definition\Resolver\AliasedInterface`).
139139
So if you want to use the `true` type name don't forget to declare it as an alias using interface.
140-
This change is for a performance mater types are lazy loaded.
140+
This change is to increase performance, types are lazy-loaded.
141141

142-
example:
142+
Here's an example:
143143

144144
```php
145145
<?php
@@ -158,7 +158,7 @@ UPGRADE FROM 0.10 to 0.11
158158

159159
**Since 0.11**: Only FQCN `App\GraphQL\Type\DateTimeType` is accessible
160160

161-
here how this can be done in 0.11:
161+
Here is how this can be done in 0.11:
162162

163163
```php
164164
<?php
@@ -189,9 +189,9 @@ UPGRADE FROM 0.10 to 0.11
189189
This could lead to some performances issues or/and wrong types public exposition (in introspection query).
190190
[See webonyx/graphql-php documentations for more details](http://webonyx.github.io/graphql-php/type-system/schema/#configuration-options)
191191

192-
**Since 0.11** Non detect types should be explicitly declare
192+
**Since 0.11** Non detect types should be explicitly declared
193193

194-
here a concrete example:
194+
Here is a concrete example:
195195
```yaml
196196
Query:
197197
type: object
@@ -222,13 +222,13 @@ UPGRADE FROM 0.10 to 0.11
222222
# ...
223223
interfaces: [FooInterface]
224224
```
225-
In above example `Baz` an `Bar` can not be detected by graphql-php during static schema analysis,
226-
an `GraphQL\Error\InvariantViolation` exception will be throw with the following message:
225+
In above example `Baz` and `Bar` can not be detected by graphql-php during static schema analysis,
226+
an `GraphQL\Error\InvariantViolation` exception will be thrown with the following message:
227227
```text
228228
Could not find possible implementing types for FooInterface in schema.
229229
Check that schema.types is defined and is an array of all possible types in the schema.
230230
```
231-
here how this can be fix:
231+
Here is how this can be fixed:
232232

233233
```yaml
234234
overblog_graphql:
@@ -241,25 +241,25 @@ UPGRADE FROM 0.10 to 0.11
241241
### Events
242242

243243
`Overblog\GraphQLBundle\Event\ExecutorContextEvent::setExecutorContext` method has been removed as `context`
244-
is now a `ArrayObject`. When using `graphql.executor.context` listener the value will now be accessible only
245-
in `context` variables and not in `rootValue`. `context` and `rootValue` has been separate, if you need to
244+
is now an `ArrayObject`. When using `graphql.executor.context` listener the value will now be accessible only
245+
in `context` variables and not in `rootValue`. `context` and `rootValue` have been separated, if you need to
246246
use `rootValue` see [event documentation for more details](Resources/doc/events/index.md).
247247

248248
**Before 0.11**
249249
`context` and `rootValue` were of type `array` with same value so `$context === $info->rootValue` and
250-
`$context === $value` in root query resolver. That for the reason why uploaded files was accessible in
250+
`$context === $value` in root query resolver. Because of this, uploaded files was accessible in
251251
`$context['request_files']` and `$info->rootValue['request_files']`.
252252

253253
**Since 0.11**
254254
`context` is of type `ArrayObject` and `rootValue` has no typeHint (default: `null`) so
255255
`$context !== $info->rootValue` and `$context !== $value` in root query resolver.
256-
Uploaded files is no more accessible under `$info->rootValue['request_files']` out of the box.
256+
Uploaded files is no longer accessible under `$info->rootValue['request_files']` out of the box.
257257

258258
### Change fluent resolvers id
259259

260-
The use of class name as prefix of fluent resolver id remove the possibility to use same class as 2 different services.
260+
The use of class name as prefix of fluent resolver id removes the possibility to use same class as 2 different services.
261261
See issue [#296](https://github.com/overblog/GraphQLBundle/issues/296) for more detail
262-
That's the reason why starting v0.11 we are using service id as prefix (like in Symfony 4.1)...
262+
Because of this, in v0.11 we are using service id as prefix (like in Symfony 4.1)...
263263

264264
Example:
265265
```yaml

0 commit comments

Comments
 (0)