Skip to content

Commit fb0477a

Browse files
regisbDawoudSheraz
authored andcommitted
fix: actually mount notes directory
Notes directory could be added via `tutor mounts add ./edx-notes-api`, but it was not actually being mounted.
1 parent 33e38b7 commit fb0477a

File tree

4 files changed

+8
-1
lines changed

4 files changed

+8
-1
lines changed
Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
- [Bugfix] Actually mount edx-notes-api repositories from host on `tutor mounts add /path/to/edx-notes-api`. (by @regisb)

tutornotes/patches/local-docker-compose-jobs-services

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4,4 +4,7 @@ notes-job:
44
DJANGO_SETTINGS_MODULE: notesserver.settings.tutor
55
volumes:
66
- ../plugins/notes/apps/settings/tutor.py:/app/edx-notes-api/notesserver/settings/tutor.py:ro
7+
{%- for mount in iter_mounts(MOUNTS, "notes") %}
8+
- {{ mount }}
9+
{%- endfor %}
710
depends_on: {{ [("mysql", RUN_MYSQL)]|list_if }}

tutornotes/patches/local-docker-compose-services

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -6,5 +6,8 @@ notes:
66
volumes:
77
- ../plugins/notes/apps/settings/tutor.py:/app/edx-notes-api/notesserver/settings/tutor.py:ro
88
- ../../data/notes:/app/data
9+
{%- for mount in iter_mounts(MOUNTS, "notes") %}
10+
- {{ mount }}
11+
{%- endfor %}
912
restart: unless-stopped
1013
depends_on: {{ [("mysql", RUN_MYSQL)]|list_if }}

tutornotes/templates/notes/apps/settings/tutor.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@
1010
"default": {
1111
"ENGINE": "django.db.backends.mysql",
1212
"HOST": "{{ MYSQL_HOST }}",
13-
"PORT": {{MYSQL_PORT}},
13+
"PORT": {{ MYSQL_PORT }},
1414
"NAME": "{{ NOTES_MYSQL_DATABASE }}",
1515
"USER": "{{ NOTES_MYSQL_USERNAME }}",
1616
"PASSWORD": "{{ NOTES_MYSQL_PASSWORD }}",

0 commit comments

Comments
 (0)