Committing changes related to visa update api review comment changes

Author: Azher2Ali

src/main/java/bio/overture/ego/controller/VisaController.java

@@ -86,8 +86,9 @@ public VisaController(
   public @ResponseBody Visa updateVisa(
       @ApiIgnore @RequestHeader(value = "Authorization", required = true)
           final String authorization,
+      @PathVariable(value = "id", required = true) UUID id,
       @RequestBody(required = true) VisaUpdateRequest visaRequest) {
-    return visaService.partialUpdate(visaRequest);
+    return visaService.partialUpdate(id, visaRequest);
   }
 
   @AdminScoped

src/main/java/bio/overture/ego/model/dto/VisaUpdateRequest.java

@@ -1,6 +1,5 @@
 package bio.overture.ego.model.dto;
 
-import java.util.UUID;
 import javax.validation.constraints.NotNull;
 import lombok.AllArgsConstructor;
 import lombok.Builder;
@@ -13,8 +12,6 @@
 @NoArgsConstructor
 public class VisaUpdateRequest {
 
-  @NotNull private UUID id;
-
   @NotNull private String type;
 
   @NotNull private String source;

src/main/java/bio/overture/ego/service/VisaService.java

@@ -11,6 +11,7 @@
 import bio.overture.ego.repository.VisaRepository;
 import java.util.Optional;
 import java.util.UUID;
+import javax.validation.constraints.NotNull;
 import lombok.NonNull;
 import lombok.extern.slf4j.Slf4j;
 import lombok.val;
@@ -74,8 +75,8 @@ public Page<Visa> listVisa(@NonNull Pageable pageable) {
     return visaRepository.findAll(pageable);
   }
 
-  public Visa partialUpdate(@NonNull VisaUpdateRequest updateRequest) {
-    val visa = getById(updateRequest.getId());
+  public Visa partialUpdate(@NotNull UUID id, @NonNull VisaUpdateRequest updateRequest) {
+    val visa = getById(id);
     VISA_CONVERTER.updateVisa(updateRequest, visa);
     return getRepository().save(visa);
   }