Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proposal to improve security with HSTS and Public-key-pins #2156

Open
onewaypub opened this issue Sep 3, 2014 · 7 comments
Open

Proposal to improve security with HSTS and Public-key-pins #2156

onewaypub opened this issue Sep 3, 2014 · 7 comments

Comments

@onewaypub
Copy link

onewaypub commented Sep 3, 2014

Since firefox (partially since 32 and full till 34) and chrome support HSTS and HTTP public key extension, I would recommend to implement these feature also in the client. This means:

  • HSTS: Client know the server has only secured communication.
  • HTTP public key extension (Public-Key-Pins (PKP)): So use this information to verify if the stored hash is okay with the hash of the given cert and is not changed. If something is wrong show a warning.
--- Want to back this issue? **[Post a bounty on it!](https://www.bountysource.com/issues/4188601-proposal-to-improve-security-with-hsts-and-public-key-pins?utm_campaign=plugin&utm_content=tracker%2F216457&utm_medium=issues&utm_source=github)** We accept bounties via [Bountysource](https://www.bountysource.com/?utm_campaign=plugin&utm_content=tracker%2F216457&utm_medium=issues&utm_source=github).
@LukasReschke
Copy link
Member

@danimo

@danimo
Copy link
Contributor

danimo commented Sep 3, 2014

Yes, this was on my mind as well, and at least HSTS should be fairly easy to implement. Any help on this is appreciated, since I cannot promise anything time-wise.

@LukasReschke
Copy link
Member

cc @karlitschek That's what we basically discussed :-)

@karlitschek
Copy link

@LukasReschke Thanks :-)

@8h2a
Copy link

8h2a commented Nov 19, 2015

Since this issue has been open vor a long time: Is there any progress or is anyone working on implementing HPKP for the client?

@danimo
Copy link
Contributor

danimo commented Nov 19, 2015

@TheDD No. It's simply not high enough on the priority list right now.

@ogoffart
Copy link
Contributor

ogoffart commented Aug 7, 2018

Qt 5.9 has QNetworkAccessManager::setStrictTransportSecurityEnabled we could use.

But since we store the redirected URL in the settings, i don't think it is necessary.

@ogoffart ogoffart added this to the 2.6.0 milestone Nov 27, 2018
@ckamm ckamm modified the milestones: 2.6.0, 2.7.0 Mar 25, 2019
@michaelstingl michaelstingl modified the milestones: 2.7.0, Backlog Mar 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

8 participants