fix(ast/estree): Add missing estree fields to TSIndexSignature and TSIndexSignatureName (#9968)

Add missing estree fields to TSIndexSignature and TSIndexSignatureName

PR is part of ongoing work to align our AST's ESTree output with that of
TS-ESLint's. Relates to #9705.

---------

Co-authored-by: Hiroshi Ogawa <[email protected]>

Author: therewillbecode

crates/oxc_ast/src/ast/ts.rs

@@ -961,6 +961,7 @@ pub enum TSSignature<'a> {
 #[ast(visit)]
 #[derive(Debug)]
 #[generate_derive(CloneIn, GetSpan, GetSpanMut, ContentEq, ESTree)]
+#[estree(add_fields(accessibility = TsNull))]
 pub struct TSIndexSignature<'a> {
     pub span: Span,
     pub parameters: Vec<'a, TSIndexSignatureName<'a>>,
@@ -1034,7 +1035,7 @@ pub struct TSConstructSignatureDeclaration<'a> {
 #[ast(visit)]
 #[derive(Debug)]
 #[generate_derive(CloneIn, GetSpan, GetSpanMut, ContentEq, ESTree)]
-#[estree(rename = "Identifier")]
+#[estree(rename = "Identifier", add_fields(decorators = TsEmptyArray, optional = TsFalse))]
 pub struct TSIndexSignatureName<'a> {
     pub span: Span,
     #[estree(json_safe)]

crates/oxc_ast/src/generated/derive_estree.rs

@@ -2896,6 +2896,7 @@ impl ESTree for TSIndexSignature<'_> {
         state.serialize_field("typeAnnotation", &self.type_annotation);
         state.serialize_field("readonly", &self.readonly);
         state.serialize_field("static", &self.r#static);
+        state.serialize_ts_field("accessibility", &crate::serialize::TsNull(self));
         state.end();
     }
 }
@@ -2962,6 +2963,8 @@ impl ESTree for TSIndexSignatureName<'_> {
         state.serialize_field("end", &self.span.end);
         state.serialize_field("name", &JsonSafeString(self.name.as_str()));
         state.serialize_field("typeAnnotation", &self.type_annotation);
+        state.serialize_ts_field("decorators", &crate::serialize::TsEmptyArray(self));
+        state.serialize_ts_field("optional", &crate::serialize::TsFalse(self));
         state.end();
     }
 }

napi/parser/deserialize-ts.js

@@ -1718,6 +1718,7 @@ function deserializeTSIndexSignature(pos) {
     typeAnnotation: deserializeBoxTSTypeAnnotation(pos + 40),
     readonly: deserializeBool(pos + 48),
     static: deserializeBool(pos + 49),
+    accessibility: null,
   };
 }
 
@@ -1766,6 +1767,8 @@ function deserializeTSIndexSignatureName(pos) {
     end: deserializeU32(pos + 4),
     name: deserializeStr(pos + 8),
     typeAnnotation: deserializeBoxTSTypeAnnotation(pos + 24),
+    decorators: [],
+    optional: false,
   };
 }
 

npm/oxc-types/types.d.ts

@@ -1205,6 +1205,7 @@ export interface TSIndexSignature extends Span {
   typeAnnotation: TSTypeAnnotation;
   readonly: boolean;
   static: boolean;
+  accessibility?: null;
 }
 
 export interface TSCallSignatureDeclaration extends Span {
@@ -1239,6 +1240,8 @@ export interface TSIndexSignatureName extends Span {
   type: 'Identifier';
   name: string;
   typeAnnotation: TSTypeAnnotation;
+  decorators?: [];
+  optional?: false;
 }
 
 export interface TSInterfaceHeritage extends Span {