fix(ast/estree): Fix FormalParameter (#9954)

Align our AST's ESTree output with that of TS-ESLint's for the
`FormalParameter` node. Relates to #9705

Skips the estree serialization of `accessibility` `readonly` and
`overrides` fields.

Author: therewillbecode

crates/oxc_ast/src/ast/js.rs

@@ -1775,10 +1775,13 @@ pub struct FormalParameter<'a> {
     #[estree(flatten)]
     pub pattern: BindingPattern<'a>,
     #[ts]
+    #[estree(skip)]
     pub accessibility: Option<TSAccessibility>,
     #[ts]
+    #[estree(skip)]
     pub readonly: bool,
     #[ts]
+    #[estree(skip)]
     pub r#override: bool,
 }
 

crates/oxc_ast/src/generated/derive_estree.rs

@@ -1382,9 +1382,6 @@ impl ESTree for FormalParameter<'_> {
         state.serialize_ts_field("typeAnnotation", &self.pattern.type_annotation);
         state.serialize_ts_field("optional", &self.pattern.optional);
         state.serialize_ts_field("decorators", &self.decorators);
-        state.serialize_ts_field("accessibility", &self.accessibility);
-        state.serialize_ts_field("readonly", &self.readonly);
-        state.serialize_ts_field("override", &self.r#override);
         state.end();
     }
 }

napi/parser/deserialize-ts.js

@@ -814,9 +814,6 @@ function deserializeFormalParameter(pos) {
     typeAnnotation: deserializeOptionBoxTSTypeAnnotation(pos + 56),
     optional: deserializeBool(pos + 64),
     decorators: deserializeVecDecorator(pos + 8),
-    accessibility: deserializeOptionTSAccessibility(pos + 72),
-    readonly: deserializeBool(pos + 73),
-    override: deserializeBool(pos + 74),
   };
 }
 

npm/oxc-types/types.d.ts

@@ -574,9 +574,6 @@ export interface FormalParameterRest extends Span {
 export type FormalParameter =
   & ({
     decorators?: Array<Decorator>;
-    accessibility?: TSAccessibility | null;
-    readonly?: boolean;
-    override?: boolean;
   })
   & BindingPattern;