Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

transformer: align API with babel #5397

Closed
Boshen opened this issue Sep 2, 2024 · 0 comments · Fixed by #5398
Closed

transformer: align API with babel #5397

Boshen opened this issue Sep 2, 2024 · 0 comments · Fixed by #5398
Assignees
@Boshen

Comments

@Boshen
Copy link
Member

Boshen commented Sep 2, 2024 

          > (On an unrelated note, `sourceText` is kinda a funny name for generated output. Renaming it is obviously breaking, but I'd suggest something like `contents` or `javascript`/`js` because "source text" makes me think it's the TypeScript source.)

We'll align everything with babel.

Originally posted by @Boshen in #5395 (comment)
@Boshen Boshen self-assigned this Sep 2, 2024
Boshen added a commit that referenced this issue Sep 2, 2024
@Boshen
feat(napi/transform)!: align output API sourceText -> code with b…
3ccda45 
…abel

And `sourceMap` -> `map`

closes #5397
@Boshen Boshen mentioned this issue Sep 2, 2024
Merged
Boshen added a commit that referenced this issue Sep 2, 2024
@Boshen
feat(napi/transform)!: align output API sourceText -> code with b…
b1d0075 
…abel (#5398)

And `sourceMap` -> `map`

closes #5397
@Boshen Boshen closed this as completed Sep 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Boshen Boshen

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(napi/transform)!: align output API sourceText -> code with babel oxc-project/oxc
1 participant
@Boshen