[sled-agent-config-reconciler] Flesh out dataset serialization task (#8088)

Author: jgallagher

Cargo.lock

@@ -58,9 +58,9 @@ pub enum DestroyDatasetErrorVariant {
 
 /// Error returned by [`Zfs::destroy_dataset`].
 #[derive(thiserror::Error, Debug)]
-#[error("Could not destroy dataset {name}: {err}")]
+#[error("Could not destroy dataset {name}")]
 pub struct DestroyDatasetError {
-    name: String,
+    pub name: String,
     #[source]
     pub err: DestroyDatasetErrorVariant,
 }
@@ -282,7 +282,7 @@ pub struct SizeDetails {
     pub compression: CompressionAlgorithm,
 }
 
-#[derive(Debug)]
+#[derive(Debug, Clone)]
 pub struct DatasetProperties {
     /// The Uuid of the dataset
     pub id: Option<DatasetUuid>,

illumos-utils/src/zfs.rs

@@ -13,6 +13,7 @@ async-trait.workspace = true
 camino.workspace = true
 camino-tempfile.workspace = true
 chrono.workspace = true
+debug-ignore.workspace = true
 derive_more.workspace = true
 dropshot.workspace = true
 futures.workspace = true
@@ -34,16 +35,19 @@ thiserror.workspace = true
 tokio.workspace = true
 tufaceous-artifact.workspace = true
 zone.workspace = true
+
 omicron-workspace-hack.workspace = true
 
 [dev-dependencies]
+assert_matches.workspace = true
 expectorate.workspace = true
 omicron-test-utils.workspace = true
 proptest.workspace = true
 scopeguard.workspace = true
 serde_json.workspace = true
-test-strategy.workspace = true
 sled-storage = { workspace = true, features = ["testing"] }
+test-strategy.workspace = true
+xshell.workspace = true
 
 [features]
 testing = []

sled-agent/config-reconciler/Cargo.toml

@@ -0,0 +1,7 @@
+# Seeds for failure cases proptest has generated in the past. It is
+# automatically read and these particular cases re-run before any
+# novel cases are generated.
+#
+# It is recommended to check this file in to source control so that
+# everyone who runs the test benefits from these saved cases.
+cc 83e4a7eb0fa4ce143d0026c5ab0a7abca8cfa2101140ba6b4e5f6aadec8928c6 # shrinks to input = _TransientZoneDatasetsSkippedIfNoTransientZoneRootArgs { pools: {ArbitraryZpoolName { name: ZpoolName { id: 00000000-0000-0000-0000-000000000000 (zpool), kind: External } }: Fail} }