Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configuration file support (TOML) tests are missing #68

Closed
jnd-au opened this issue Oct 17, 2024 · 1 comment · Fixed by #69
Closed

Configuration file support (TOML) tests are missing #68

jnd-au opened this issue Oct 17, 2024 · 1 comment · Fixed by #69

Comments

@jnd-au
Copy link
Contributor

jnd-au commented Oct 17, 2024

TOML config file support (and associated logging) was recently added to tz (#1) but it lacks unit tests:

  1. It reduced HEAD unit-test coverage from 42% to 31%, and reduced coverage from 84% to 73% in PR Daylight Saving Time (DST) support #59 #62.
  2. It introduced user-impacting changes of behaviour, bugs, or blockers like: Conflicting keymaps (config-related) #63 Crash: SIGSEGV: segmentation violation (config-related) #65 Regression: Missing UTC (config-related) #66

Therefore, config file parsing is a significant surface area for unit testing.

Furthermore, testing is needed for the configuration environment-variable support, but this is already included with bugfixes in PR #62.

@jnd-au
Copy link
Contributor Author

jnd-au commented Oct 17, 2024

Furthermore, the config file functions need to be parameterised to unblock unit testing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant