add comments

Author: p-mazhnik

expo-flutter/README.md

@@ -110,7 +110,7 @@ $ npm run flutter:build:web
 Then run `expo prebuild` command to prepare the Expo app:
 
 ```console
-$ npx expo prebuild --clean
+$ npx expo prebuild
 ```
 
 Finally, run the `npm run <platfrom>` command to start the Expo app on the desired platform:

expo-flutter/modules/expo-flutter-view/plugin/src/index.ts

@@ -83,6 +83,8 @@ const withFlutter: ConfigPlugin = config => {
     const podfile = path.join(config.modRequest.platformProjectRoot, 'Podfile');
     const projectRoot = config.modRequest.projectRoot
 
+    // Inject Flutter pods into the Podfile
+    // TODO(p-mazhnik): to avoid frequent Podfile updates, logic below could be extracted to the custom ruby script
     const pluginsDir = path.join(projectRoot, 'modules/expo-flutter-view/ios/Flutter/plugins');
     const flutterIosPluginPods = []
     flutterIosPluginPods.push('  pod \'Flutter\', :podspec => \'../modules/expo-flutter-view/ios/Flutter/Flutter.podspec\'');

expo-flutter/scripts/flutter_build_ios.sh

@@ -1,5 +1,8 @@
 rm -rf modules/expo-flutter-view/ios/Flutter
 cd flutter_module
+# Use --no-plugins here, so flutter plugins won't be built as xcframeworks and will be handled by expo's Podfile.
+# This is needed to resolve conflicts between flutter and expo native ios dependencies and build configs.
+# See also https://github.com/p-mazhnik/flutter-embedding/issues/16 and https://github.com/flutter/flutter/issues/130220
 flutter build ios-framework --no-plugins --cocoapods --output=../modules/expo-flutter-view/ios/Flutter
 cd -
 cd modules/expo-flutter-view/ios/Flutter
@@ -8,4 +11,6 @@ zip -rm Debug.zip Debug
 zip -rm Release.zip Release
 zip -rm Profile.zip Profile
 cd -
+# Copy flutter ios plugins from flutter_module to expo-flutter-view
+# They will be injected to expo's Podfile by plugin
 node ./scripts/prepare_ios_plugins.js