Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate with ebay official auth module #93

Closed
pajaydev opened this issue May 17, 2020 · 5 comments · Fixed by #99
Closed

Integrate with ebay official auth module #93

pajaydev opened this issue May 17, 2020 · 5 comments · Fixed by #99
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@pajaydev
Copy link
Owner

use the below library to generate the access token.

https://github.com/eBay/ebay-oauth-nodejs-client

@TotallyNotChase
Copy link
Contributor

Right, will we be just importing that library or should we copy the code from there to here? I think making this api standalone without the need of another ebay oauth package would be a good idea. As I mentioned in #10 I'm working on implementing this right now.

@pajaydev
Copy link
Owner Author

@TotallyNotChase am okay with it but I thought we need sync this library with this one. Free feel to take this up. Kindly let me know if you need any help.

Thanks. I appreciate it.

@TotallyNotChase
Copy link
Contributor

@pajaydev yep working on it right now. What exactly do you mean by sync btw?

@TotallyNotChase
Copy link
Contributor

@pajaydev quick update, I deployed the changes here. I'd appreciate it if you could take a look and let me know if you're ok with these. I'll do a bit more bugtesting as soon as I get a chance and PR if you're ok with it.

@TotallyNotChase
Copy link
Contributor

TotallyNotChase commented May 23, 2020 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
2 participants