-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integrate with ebay official auth module #93
Comments
Right, will we be just importing that library or should we copy the code from there to here? I think making this api standalone without the need of another ebay oauth package would be a good idea. As I mentioned in #10 I'm working on implementing this right now. |
@TotallyNotChase am okay with it but I thought we need sync this library with this one. Free feel to take this up. Kindly let me know if you need any help. Thanks. I appreciate it. |
@pajaydev yep working on it right now. What exactly do you mean by sync btw? |
@pajaydev Hello again, did you get a chance to review the oauth branch?
I'm writing this to inform you that some bad weather has wrecked my
internet connectivity and hence I wasn't able to make a PR for the full
oauth flow yet. But rest assured, I'll be making one as soon as my comms
are fixed.
I also noticed you rolled out a new version and made sure to apply those
changes to my oauth branch. Although I couldn't push them up due to my
internet.
If there's anything you'd like me to know, or do in the oauth branch,
before making a PR to the main repo (once I am able to), let me know.
|
use the below library to generate the access token.
https://github.com/eBay/ebay-oauth-nodejs-client
The text was updated successfully, but these errors were encountered: