Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RUSTSEC-2024-0370: proc-macro-error is unmaintained #116

Closed
vsirivol opened this issue Nov 1, 2024 · 2 comments
Closed

RUSTSEC-2024-0370: proc-macro-error is unmaintained #116

vsirivol opened this issue Nov 1, 2024 · 2 comments

Comments

@vsirivol
Copy link
Contributor

vsirivol commented Nov 1, 2024

This repo is using proc-macro2 v1.0.71 and this is causing the issue.

proc-macro-error is unmaintained and is updated to proc-macro-error2: jbaublitz/getset#94

proc-macro2 v1.0.89 has the updated code.

@palfrey
Copy link
Owner

palfrey commented Nov 2, 2024

proc-macro2 can be upgraded in something that depends on this, and now #118 is in, we know that upgrade will still be safe. I don't feel the need to upgrade the dependency here, as we're not blocking other packages from doing that upgrade while using serial_test, especially as we don't use proc-macro-error directly here.

@palfrey palfrey closed this as completed Nov 2, 2024
@vsirivol
Copy link
Contributor Author

vsirivol commented Nov 2, 2024

Thanks for addressing proc-macro2 upgrade by adding the new step in workflow. But I am a little confused because I don't see that the version update for proc-macro2 is done in the Cargo.lock file. Also I believe according to the workflow trigger, it has to update when there is a push, pull or a crone job that runs every month.

Please feel to correct me if I am wrong or if it takes a little more time before the lock file is updated after pushing the update.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants