-
-
Notifications
You must be signed in to change notification settings - Fork 155
Add index and columns as properties to Styler
#1135
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
/pandas_nightly |
Dr-Irv
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You have issues with some formatting and ordering of imports.
You should set up the pre-commit so things are properly formatted. See the output here:
https://github.com/pandas-dev/pandas-stubs/actions/runs/13605234204/job/38040314429?pr=1135
And instructions here for setting up your local testing environment:
https://github.com/pandas-dev/pandas-stubs/blob/main/docs/setup.md
Sure, I will make the changes, I actually had some trouble setting up the development environment following those instructions. For some reason unless I disable the KMP_AFFINITY pytest just crashes. |
|
/pandas_nightly |
Hi @Dr-Irv, This is now completed, PTAL. Thanks for the instructions and feedback. |
Dr-Irv
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks @Rishab260
Stylerhas no.columnsattr defined #1102test_styler_columns_and_indexintests/test_styler.py.pytest tests/test_styler.pyandmypy tests/test_styler.pyChanges As Per Discussion
indexandcolumnsto Styler instyle.pyiindexandcolumnsRelated Issues and PRs
Styler.columnsandStyler.indexpandas#60815Also See [Source: link ]
Output:
Additional Comments
First PR on pandas-stubs, your feedback will be highly valuable to me, Thanks!