Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

labelsize arguments need fixes #852

Closed
Dr-Irv opened this issue Jan 14, 2024 · 0 comments · Fixed by #1011
Closed

labelsize arguments need fixes #852

Dr-Irv opened this issue Jan 14, 2024 · 0 comments · Fixed by #1011

Comments

@Dr-Irv
Copy link
Collaborator

Dr-Irv commented Jan 14, 2024 

          Oh , the upstream docs of this, and other label size usages, will need to be updated to accept `float | str | None` (See the [matplotlib docs](https://matplotlib.org/stable/api/_as_gen/matplotlib.axes.Axes.tick_params.html)). I typed them as `int | None` here for now because they need to be fixed everywhere in pandas-stubs, not just this file. We can do that in a separate PR.

Originally posted by @hamdanal in #848 (comment)

Probably needs fixes in the stubs and in pandas docs
@Dr-Irv Dr-Irv mentioned this issue Jan 14, 2024
Merged
2 tasks
loicdiridollou added a commit to loicdiridollou/pandas-stubs that referenced this issue Oct 4, 2024
@loicdiridollou
pandas-devGH-852 Typehint labelsize
6407fc8
@loicdiridollou loicdiridollou mentioned this issue Oct 4, 2024
Merged
2 tasks
Dr-Irv pushed a commit that referenced this issue Oct 7, 2024
@loicdiridollou
GH852 Typehint labelsize (#1011)
e50358f 
GH-852 Typehint labelsize
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

GH852 Typehint labelsize loicdiridollou/pandas-stubs
1 participant
@Dr-Irv